Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort plots by modify time? #134

Open
kb1ooo opened this issue Mar 12, 2020 · 3 comments
Open

sort plots by modify time? #134

kb1ooo opened this issue Mar 12, 2020 · 3 comments

Comments

@kb1ooo
Copy link

kb1ooo commented Mar 12, 2020

I think it would be more natural to display all plots in creation/modification order? I think changing line 121 in kernel.py from

for fname in sorted(os.listdir(tmpdir)):

to

for fname in sorted(os.listdir(tmpdir), key=os.path.getmtime)):

would do it. Thoughts?

@blink1073
Copy link
Contributor

Sounds good! Do you mind giving it a shot and submitting a PR?

@kb1ooo
Copy link
Author

kb1ooo commented Mar 13, 2020

@blink1073 will do. Trying to carve out some time to do this update and try my idea on pushing images as they are generated. Can you point me to some info on the best way to iterate on developing and testing kernel updates?

@blink1073
Copy link
Contributor

Great! I added a section to the docs: https://github.com/Calysto/matlab_kernel#development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants