Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a MagicSelect #4

Merged
merged 25 commits into from
Jul 7, 2018
Merged

Add a MagicSelect #4

merged 25 commits into from
Jul 7, 2018

Conversation

Shelob9
Copy link
Contributor

@Shelob9 Shelob9 commented Jul 5, 2018

This PR will add a a MagicSelect field to serve as a basic v2 replacement for magic tags as currently implemented in Caldera Forms. #1

@coveralls
Copy link

coveralls commented Jul 5, 2018

Pull Request Test Coverage Report for Build 31

  • 80 of 81 (98.77%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 93.996%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/fields/magic-select/MagicSelect.js 18 19 94.74%
Totals Coverage Status
Change from base Build 5: 0.7%
Covered Lines: 318
Relevant Lines: 331

💛 - Coveralls

@@ -8,44 +8,57 @@ import PropTypes from 'prop-types';
/**
* Create magic item for option of magic selects
*
* This can not be a functional component
* https://github.com/reactjs/react-autocomplete/pull/293#issuecomment-371617758
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shelob9 Shelob9 changed the title [WIP] Add a MagicSelect Add a MagicSelect Jul 7, 2018
@Shelob9 Shelob9 merged commit d8b8f83 into master Jul 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants