Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use one webpack build for pro and blocks #2444

Merged
merged 12 commits into from
Apr 19, 2018
Merged

Use one webpack build for pro and blocks #2444

merged 12 commits into from
Apr 19, 2018

Conversation

Shelob9
Copy link
Collaborator

@Shelob9 Shelob9 commented Apr 19, 2018

I tried to get edit and admin into webpack, too much stuff breaks. It's going to need more work or a rewrite.

This PR uses one webpack config to build pro admin ui and blocks. It leaves a place for admin and entry view clients.

Resolves:
#2167

TODO:

  • Update build script to include production parts.
  • Consider moving files back to where they originally where during build

Out of scope:

@Shelob9 Shelob9 merged commit 3eb9c33 into develop Apr 19, 2018
@Shelob9 Shelob9 mentioned this pull request May 24, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR (Patch) Is a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant