Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Translucency Sort Triggering at Very High Camera Coordinates #3051

Merged

Conversation

douira
Copy link
Collaborator

@douira douira commented Feb 27, 2025

Fix translucency sort triggering at very high camera coordinates (like around 16 million) by using full double precision in the calculation of the NormalPlanes's dot product offset.

…ates (like around 16 million) by using full double precision in the calculation of the NormalPlanes's dot product offset
@douira
Copy link
Collaborator Author

douira commented Feb 27, 2025

I haven't observed this being a problem in trunk and it was only discovered as part of testing on the quad splitting branch.

@jellysquid3 jellysquid3 merged commit fe5fe6c into CaffeineMC:dev Feb 27, 2025
1 check passed
MoePus pushed a commit to MoePus/sodium that referenced this pull request Mar 2, 2025
…ineMC#3051)

This fixes translucency sort triggering when very large camera coordinates are involved (~16 million blocks away from world center) by using full double precision in the calculation of the NormalPlanes's dot product offset.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants