Fix SNR Sorting #3027
Merged
Fix SNR Sorting #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay and add comment explaining this tricky behavior.
jellysquid3
approved these changes
Feb 16, 2025
MoePus
pushed a commit
to MoePus/sodium
that referenced
this pull request
Mar 2, 2025
This changes SNR sorting to use correct (continuous) indexing of the quads array and adds a comment explaining the tricky behavior. Resolves the regression introduced with d74e421 ("Improve vertex sorting code and use radix sorts").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SNR sorting to use correct (continuous) indexing of the quads array and add comment explaining this tricky behavior.