Apply BufferBuilder optimizations via delegate #2241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I rebased this on dev (it rebases clean) and ran it in RestWorld in combination with the Caxton mod.
Overall that looks good. |
jellysquid3
approved these changes
Jan 26, 2024
| this.writtenAttributes = 0; | ||
| } | ||
|
|
||
| public void reset() { |
There was a problem hiding this comment.
This doesn't appear to be used.
jellysquid3
added a commit
that referenced
this pull request
Feb 12, 2024
This reverts commit 3980cc5.
thejudge156
pushed a commit
to QuestCraftPlusPlus/sodium-fabric
that referenced
this pull request
Mar 31, 2024
…ineMC#2241)"" This reverts commit 3621222.
IMS212
pushed a commit
to IMS212/sodium-fabric
that referenced
this pull request
Aug 6, 2024
IMS212
added a commit
to IMS212/sodium-fabric
that referenced
this pull request
Aug 6, 2024
…)" This reverts commit e8930d4.
IMS212
pushed a commit
to IMS212/sodium-fabric
that referenced
this pull request
Aug 6, 2024
)" This reverts commit e4039a7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #2240. The original
BufferBuildermethod implementations have been restored, and a new wrapper class is created that is returned byVertexConsumerProvider.Immediate.Please feel free to critique the implementation; it was put together relatively quickly (and then many hours were spent debugging batching being broken).