Add bounds checking in WorldSlice #2173
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, calling
WorldSlice#getBlockState
or related methods with a block position that wasn't cloned will either returnnull
or throwArrayIndexOutOfBoundsException
. This tends to cause crashes in mods, and is not very useful for debugging.To solve this, we check that the given position is within bounds, and return a sane default value if not:
Blocks.AIR.getDefaultState()
for block statesnull
for block entities and block entity render attachments