Fix biome colors being retrieved differently from vanilla #2131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a parity issue with how biome colors are retrieved compared to vanilla. Vanilla uses the lambdas in the
static finalfields ofBiomeColorsin order to call the appropriate methods on the biome, while Sodium just calls them directly. This causes compatibility issues with mods that use an AT/AW and replace the lambda in those fields to add custom logic.In the case where no mod has replaced the lambda, the behavior of this patch should be exactly the same as Sodium 0.5.3, as the lambda delegates to the same method Sodium would have called.