Fix parity issue in Sodium's getFacing optimization #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doing this check explicitly feels cleaner than manipulating the other statements, also because it avoids needing to calculate the absolute values in that case. Though I suspect either way doesn't have any performance relevance. |
IMS212
added a commit
to IMS212/sodium-fabric
that referenced
this pull request
Aug 6, 2024
Fix parity issue in Sodium's getFacing optimization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The optimization introduced in #1587 has a subtle parity issue: if
x, y, zare all zero, Sodium'sDirection.getFacingimplementation returnsDirection.DOWN, while vanilla returnsDirection.NORTH. This could potentially cause modded code to crash if it implicitly assumed that the returned direction was horizontal in this case (I believe this caused AlexModGuy/Ice_and_Fire#4767).This PR fixes that by checking for this corner case and returning the same value as vanilla. An alternate solution would be to reorder the chain of if statements such that NORTH would end up being selected.