Improve fog shader parity to match vanilla #2097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Handle the case where end < start the same way vanilla does (by re-adding the comparison checks) * Multiply fog alpha in the correct place
IMS212
added a commit
to IMS212/sodium-fabric
that referenced
this pull request
Aug 6, 2024
Improve fog shader parity to match vanilla
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a parity issue between the Sodium and vanilla fog shaders in the (admittedly undefined) case that
fogEnd < fogStart. In this scenario, the original Sodium shader appears to produce fog filling the screen, while vanilla simply renders no fog at all. This appears to be caused by the conditional checks which were present in the vanilla function being removed.I fixed this issue by restoring the conditionals, and also took the opportunity to fix the alpha component of the fog color being multiplied in the wrong place, as pointed out by a user on Discord, and verbally endorsed by JellySquid at the time.
The new function appears to give identical results to vanilla.