Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default option for Vignette #2521

Open
tildejustin opened this issue May 29, 2024 · 0 comments
Open

Default option for Vignette #2521

tildejustin opened this issue May 29, 2024 · 0 comments
Labels
F-good-first-issue Flag: Good first issue for new contributors T-enhancement Type: Enhancement

Comments

@tildejustin
Copy link

tildejustin commented May 29, 2024

Request Description

In vanilla, vignette has no specific toggle. It is instead controlled by the Graphics Mode, with it being on for Fancy or better. In sodium, Vignette is configurable, but unlike the other independent graphics configuration options (leaves, weather), it is only a boolean. I made an implementation of this (tildejustin@31c07e2), but the JSON handling is not very pretty, I can make a PR if it's deemed to be ok. handing the type change of enable_vignette in sodium-options.json is the main issue with implementing this change and maybe it would be better to just rename the field. This request was discussed a bit in the discord (https://discord.com/channels/602796788608401408/651120262129123330/1225850862698758246), just making an issue as a follow-up.

@tildejustin tildejustin added S-needs-triage Status: Needs triage T-enhancement Type: Enhancement labels May 29, 2024
@jellysquid3 jellysquid3 added F-good-first-issue Flag: Good first issue for new contributors and removed S-needs-triage Status: Needs triage labels Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F-good-first-issue Flag: Good first issue for new contributors T-enhancement Type: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants