Fix issues with number formatting #5669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good workd @ddb4github |
|
@ddb4github, can you also draft on for the develop branch? There was a fundamental file separation that makes cherry picking this impossible into develop. |
ddb4github
added a commit
to ddb4github/cacti
that referenced
this pull request
Feb 21, 2024
…acti#5669) * Show wrong number if value larger than 1000 and use __() + number_format_i18n * Update CHANGELOG for PR#5669
Yes, related code is moved to support.php. PR#5674 is created |
netniV
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alternately, we can use number_format because number_format_i18n does not support to remove thousands_separator