Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rrdcheck new tests #4999

Merged
merged 5 commits into from
Nov 11, 2022
Merged

Rrdcheck new tests #4999

merged 5 commits into from
Nov 11, 2022

Conversation

xmacan
Copy link
Member

@xmacan xmacan commented Nov 10, 2022

fix issue#2871

new tests:

  • Number of DSs in database is lower than in RRD file/DS name exists in RRA file, but not in database
  • RRD file is not writable
  • Last update value in RRD file is older than 1 hour
  • Database DS name is empty. Local data ID = ...
  • DS name exists in DB, but not in RRA file
  • ...

@TheWitness - I think I misunderstood your edit start - stop - duration changes. Duration is now 173940, I would expect something around 86400. RRD check on my data is now running longer than before. Or is it a combination of my code and yours?

Please test it

@TheWitness TheWitness merged commit 4a9d0a8 into Cacti:1.2.x Nov 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants