Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PHP 8.3 support #5622

Closed
HQuest opened this issue Dec 20, 2023 · 2 comments
Closed

Improve PHP 8.3 support #5622

HQuest opened this issue Dec 20, 2023 · 2 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone

Comments

@HQuest
Copy link

HQuest commented Dec 20, 2023

ERROR PHP ERROR: Could not set timer: Invalid argument (22) in file: cacti-1.2.25/graph_templates.php on line: 34

Offending line:
ini_set('max_execution_time', '-1');
Changing value to 0 allows unlimited execution time and resolves the error.

ERROR PHP DEPRECATED: Increment on non-alphanumeric string is deprecated in file: cacti-1.2.25/lib/html.php on line: 936
Offending line:
$page++;
Changing to "$page = (int)$page + 1;" looks less developer-y but resolves the deprecation.

Both can be experienced when going Console > Templates > Graph.

@HQuest HQuest added bug Undesired behaviour unverified Some days we don't have a clue labels Dec 20, 2023
@HQuest HQuest changed the title Errors and deprecation warnings with PHP 8 Errors and deprecation warnings with PHP 8.3.0 Dec 20, 2023
@TheWitness
Copy link
Member

Hmm. Nice catch PHP ;) We will fix this post 1.2.26.

@TheWitness TheWitness added confirmed Bug is confirm by dev team and removed unverified Some days we don't have a clue labels Jan 28, 2024
TheWitness added a commit that referenced this issue Jan 28, 2024
Errors and deprecation warnings with PHP 8.3.0
TheWitness added a commit that referenced this issue Jan 28, 2024
Errors and deprecation warnings with PHP 8.3.0
@TheWitness TheWitness added the resolved A fixed issue label Jan 28, 2024
@TheWitness
Copy link
Member

This is fixed now. Thanks for taking the time to report.

@TheWitness TheWitness added this to the 1.2.27 milestone Jan 28, 2024
@netniV netniV changed the title Errors and deprecation warnings with PHP 8.3.0 Improve PHP 8.3 support Apr 28, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

2 participants