Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When parsing a Data Query resource, an error can be reported if no direction is specified #5609

Closed
TheWitness opened this issue Dec 8, 2023 · 0 comments
Closed

When parsing a Data Query resource, an error can be reported if no direction is specified #5609

TheWitness opened this issue Dec 8, 2023 · 0 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone
1.2.26

Comments

@TheWitness
Copy link
Member

Describe the bug

Cacti generates an XML error when there is no 'direction' XML field specified for a Data Query field. This was noted in the following forum post: http://forums.cacti.net/viewtopic.php?p=293505#p293505

To Reproduce

Steps to reproduce the behavior:

  1. Create an Data Query XML file

  2. Include many fields, one that does not have a 'direction' attribute

  3. Run the Data Query

  4. See error

Expected behavior

Cacti should be able to handle this circumstance without warnings.
@TheWitness TheWitness added bug Undesired behaviour confirmed Bug is confirm by dev team labels Dec 8, 2023
@TheWitness TheWitness added this to the 1.2.26 milestone Dec 8, 2023
TheWitness added a commit that referenced this issue Dec 8, 2023
@TheWitness
Fixing Issue #5609 - Improper XML File generate warning
9460e1d 
XML Bug when parsing Data Query XML Resource File when no field direction attribute is specified
@TheWitness TheWitness changed the title XML Bug when parsing Data Query XML Resrouce File when no field direction attribute is specificed XML Bug when parsing Data Query XML Resource File when no field direction attribute is specified Dec 8, 2023
@TheWitness TheWitness added the resolved A fixed issue label Dec 8, 2023
TheWitness added a commit that referenced this issue Dec 8, 2023
@TheWitness
Fixing Issue #5609 - Improper XML File generate warning
d209b60 
XML Bug when parsing Data Query XML Resource File when no field direction attribute is specified
TheWitness added a commit that referenced this issue Dec 12, 2023
@TheWitness
QA: Additional fixing on #5609
88118a5 
This will add a subsequent check when the XML is damaged to allow the device to be created.
TheWitness added a commit that referenced this issue Dec 12, 2023
@TheWitness
QA: Additional fixing on #5609
ff61d77 
This will add a subsequent check when the XML is damaged to allow the device to be created.
@netniV netniV changed the title XML Bug when parsing Data Query XML Resource File when no field direction attribute is specified When parsing a Data Query resource, an error can be reported if no direction is specified Dec 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Milestone
1.2.26
Development

No branches or pull requests
1 participant
@TheWitness