Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Untemplated Data Sources can fail to update due to lack of an assigned Graph #5384

Closed
TheWitness opened this issue Jun 20, 2023 · 0 comments
Closed

Untemplated Data Sources can fail to update due to lack of an assigned Graph #5384

TheWitness opened this issue Jun 20, 2023 · 0 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team data collection Issues related to data collection porting required Requires porting to develop resolved A fixed issue
Milestone
v1.2.25

Comments

@TheWitness
Copy link
Member

Describe the bug

Starting in Cacti 1.2.24, Cacti started looking at the Graph assignments for Data Sources so as to reduce the amount of storage required for RRDfiles. If there was a Data Source in that Data Template that was not used for a Graph, don't create and RRDfile for it. However, this approach will break the behavior of Stand Along Data Sources as they are created independent of the Graph Template.

To Reproduce

Steps to reproduce the behavior:

  1. Manually Create a Data Source mapped to some Data Input Method

  2. Watch the Cacti Log for errors like entries left in the poller output table for that new Data Source

Expected behavior

Cacti should properly handle this special case of Data Source properly.
@TheWitness TheWitness added bug Undesired behaviour data collection Issues related to data collection confirmed Bug is confirm by dev team porting required Requires porting to develop labels Jun 20, 2023
@TheWitness TheWitness added this to the v1.2.25 milestone Jun 20, 2023
TheWitness added a commit that referenced this issue Jun 21, 2023
@TheWitness
Fixing #5384 - Untemplated Data Source Issue
63e654a 
* Untemplated Data Sources can fail to update due to lack of an assigned Graph
* Related to #5336.  We missed the case of the untemplated data source when we fixed this, and another issue in release 1.2.24.

This will allow objects such as RTM's ELIM Templates to properly create RRDfiles and operate as it does today.
@TheWitness TheWitness added the resolved A fixed issue label Jun 21, 2023
TheWitness added a commit that referenced this issue Jun 21, 2023
@TheWitness
Fixing #5384 - Untemplated Data Source Issue
ab9dd54 
* Untemplated Data Sources can fail to update due to lack of an assigned Graph
* Related to #5336.  We missed the case of the untemplated data source when we fixed this, and another issue in release 1.2.24.

This will allow objects such as RTM's ELIM Templates to properly create RRDfiles and operate as it does today.
TheWitness added a commit that referenced this issue Jun 22, 2023
@TheWitness
Additional Update to #5384
bd95317 
When the data source is orphaned and the re-index is good, reset the orphans, and if they were purged, re-introduce them.
TheWitness added a commit that referenced this issue Jun 22, 2023
@TheWitness
Revert "Additional Update to #5384"
3845fa0 
This reverts commit bd95317.
@netniV netniV mentioned this issue Jun 23, 2023
Merged
TheWitness added a commit that referenced this issue Jul 31, 2023
@TheWitness
QA: for #5384 and #5430
828c953 
For non-templated Data Sources we should keep discard the unused use.
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team data collection Issues related to data collection porting required Requires porting to develop resolved A fixed issue
Projects
None yet
Milestone
v1.2.25
Development

No branches or pull requests
1 participant
@TheWitness