When viewing a graph, Edit Graph Template link may open wrong url

[jlrcontegix]

Describe the bug

In graph views where the "Edit Graph Template" button/link is displayed to the right of the graph, the link points to https://graph_templates.php/?action=template_edit&id=XX

All other links render properly.

To Reproduce

Steps to reproduce the behavior:

1. Navigate to instance's /graph_view.php

2. Click on "Edit Graph Template" next to a graph, or hover over link and view URL.

3. Link renders without base_url value leading to an error from the browser.

Expected behavior

The link should render with the base_url like other links.

Desktop (please complete the following information)

• OS: MacOS Ventura

• Browser Chrome

• Version 109

Additional context

The only difference from a typical install is we are not using /cacti/ as the url_path, but instead /. I have tinkered with the Server Base URL value in Settings, by completely removing it, trying just the FQDN, and also https://FQDN, but no change in link rendering.

Cacti Version: 1.2.23
PHP 8.2.3
CentOS 7

[TheWitness]

This appears to be more of a configuration issue on your part.

[TheWitness]

The default $url_path should be '/cacti/'

[jlrcontegix]

That's the default, but why give the option if you can't change it? We do not want to deploy Cacti at /cacti/ and never have.

[TheWitness]

You can change it in config.php.

[jlrcontegix]

Perhaps I was not clear enough, I have $url_path defined in config.php as '/'. Only the Edit Graph Template link next to graphs renders incorrectly.

[jlrcontegix]

On an instance where /cacti/ is used there is an extra slash rendered in the Edit Graph Template link:

https://some.url.tld/cacti//graph_templates.php?action=template_edit&id=100

[TheWitness]

Can you show a screen shot of where this link it highlighting the screen shot so that I know specifically where you are experiencing the bad link?

[jlrcontegix]

Sure thing, and sorry about the base_url confusion, I've been working on migrating another app with a proxy issue rendering links incorrectly with that variable and got my wires crossed.

[TheWitness]

Cool, that helps. It's the slash at the end of the .php that is causing the issue.

[TheWitness]

Resolved in the soon to be merged #5238

[TheWitness]

All ported to 1.3.x now.