Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching language in the settings does not immediately become active #5161

Closed
paulgevers opened this issue Jan 13, 2023 · 5 comments
Closed

Switching language in the settings does not immediately become active #5161

paulgevers opened this issue Jan 13, 2023 · 5 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone
v1.2.24

Comments

@paulgevers
Copy link
Contributor

Describe the bug

While debugging issue #5160 I noticed that if I switch the language in the settings.php page, they do not become active. I can active the language by clearing my session cookie.

To Reproduce

  1. Go to '/cacti/settings.php'

  2. Change the value under 'language' and set 'Auto Language Detection' to Disabled

  3. Hit the Save button

  4. See the pop-up window appearing in the original language.

Expected behavior

Selected language becomes active immediately

Desktop (please complete the following information)

  • OS: Linux on Debian bookworm

  • Browser: Firefox

  • Version: 102.6.0esr
@paulgevers paulgevers added bug Undesired behaviour unverified Some days we don't have a clue labels Jan 13, 2023
@TheWitness TheWitness added confirmed Bug is confirm by dev team and removed unverified Some days we don't have a clue labels Jan 16, 2023
@TheWitness TheWitness added this to the v1.2.24 milestone Jan 16, 2023
TheWitness added a commit that referenced this issue Jan 16, 2023
@TheWitness
Fixing #5161 - Lang Autodetect
446c1d6 
Switching language in the settings only becomes active after removal of session cookie
@TheWitness TheWitness added the resolved A fixed issue label Jan 16, 2023
@TheWitness
Copy link
Member

@paulgevers, please test with the latest settings.php in the 1.2.x branch.

@TheWitness TheWitness changed the title [1.2.23] Switching language in the settings only becomes active after removal of session cookie Switching language in the settings only becomes active after removal of session cookie Jan 16, 2023
TheWitness added a commit that referenced this issue Jan 19, 2023
@TheWitness
Fixing #5161 - Lang Auto Detect Switching
f150603
TheWitness added a commit that referenced this issue Jan 19, 2023
@TheWitness
QA for #5161
942a7d6 
Failed to initialize variable.
@paulgevers
Copy link
Contributor Author

@TheWitness I was finally able to check it. I'm sorry to say but with only commit 446c1d6, it doesn't seem to work for me.

@TheWitness
Copy link
Member

TheWitness commented Jan 19, 2023 •
edited
Loading

@paulgevers, could you provide a screen2gif of the UI action?

@paulgevers
Copy link
Contributor Author

vokoscreenNG-2023-01-19_21-04-35.webm

@TheWitness
Copy link
Member

Okay, I addressed a different issue, but same process. On it.

TheWitness added a commit that referenced this issue Jan 21, 2023
@TheWitness
Improve solution around #5161
a082f37 
This will make sure a refresh happens when any of the three values change.  Should be good enough.
TheWitness added a commit that referenced this issue Jan 22, 2023
@TheWitness
Porting #5161 to develop
83bd6cc
TheWitness added a commit that referenced this issue Jan 22, 2023
@TheWitness
Updating CHANGELOG
5b1b8fc 
Confirmed #5150, #5151, #5159, #5161, #5167, #5168, #5174
@netniV netniV changed the title Switching language in the settings only becomes active after removal of session cookie Switching language in the settings does not immediately become active Feb 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Milestone
v1.2.24
Development

No branches or pull requests
2 participants
@TheWitness @paulgevers