Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph watermark is not escaped properly, leading to broken graphs #5066

Closed
TheWitness opened this issue Dec 7, 2022 · 2 comments
Closed

Graph watermark is not escaped properly, leading to broken graphs #5066

TheWitness opened this issue Dec 7, 2022 · 2 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Milestone
v1.2.23

Comments

@TheWitness
Copy link
Member

Describe the bug

Out a single quoted in your watermark and watch your graphs break.

Expected behavior

A safer less disruptful Cacti.
@TheWitness TheWitness added bug Undesired behaviour unverified Some days we don't have a clue labels Dec 7, 2022
@TheWitness TheWitness added this to the v1.2.23 milestone Dec 7, 2022
@TheWitness TheWitness changed the title cacti does not escape the watermark leading to broken graphs 1.2.23 - Cacti does not escape the watermark leading to broken graphs Dec 7, 2022
@bmfmancini
Copy link
Member

Also see this on 1.3.x

image

image

TheWitness added a commit that referenced this issue Dec 8, 2022
@TheWitness
Fixing #5066 - Watermark issues
465d424 
Cacti does not escape the watermark leading to broken graphs
@TheWitness TheWitness added resolved A fixed issue confirmed Bug is confirm by dev team and removed unverified Some days we don't have a clue labels Dec 8, 2022
@TheWitness
Copy link
Member Author

Okay, this is resolved now.

@netniV netniV changed the title 1.2.23 - Cacti does not escape the watermark leading to broken graphs Graph watermark is not escaped properly, leading to broken graphs Dec 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue
Projects
None yet
Milestone
v1.2.23
Development

No branches or pull requests
2 participants
@TheWitness @bmfmancini