Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors can occur when attempting to remove items from CDEF or VDEF's #5006

Closed
xmacan opened this issue Nov 14, 2022 · 8 comments
Closed

Errors can occur when attempting to remove items from CDEF or VDEF's #5006

xmacan opened this issue Nov 14, 2022 · 8 comments
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue unverified Some days we don't have a clue
Milestone
v1.2.23

Comments

@xmacan
Copy link
Member

xmacan commented Nov 14, 2022

Create new cdef or vdef, add any item and try to delete the item. I got:
(/vdef.php[75]:vdef_edit(), /vdef.php[539]:get_filter_request_var(), /lib/html_utility.php[493]:die_html_input_error(), /lib/html_validate.php[64]:cacti_debug_backtrace())

(/cdef.php[85]:cdef_edit(), /cdef.php[565]:get_filter_request_var(), /lib/html_utility.php[493]:die_html_input_error(), /lib/html_validate.php[64]:cacti_debug_backtrace())

It is connected with themes. With PAW I got error,in midwinter without error.

1.2.23
@xmacan xmacan added bug Undesired behaviour unverified Some days we don't have a clue labels Nov 14, 2022
@TheWitness
Copy link
Member

I'm unable to reproduce. Go to the Debug windows Network tab and show the post values.

@TheWitness TheWitness added the unable to reproduce We don't have a clue label Nov 16, 2022
@xmacan
Copy link
Member Author

xmacan commented Nov 16, 2022

cacti_cdef

@xmacan
Copy link
Member Author

xmacan commented Nov 16, 2022

Tested with firewfox and edge

@TheWitness
Copy link
Member

Highlight the POST and show the request subtab.

@xmacan
Copy link
Member Author

xmacan commented Nov 17, 2022

[17/Nov/2022:17:29:07 +0100] "GET /cdef.php?action=item_remove_confirm&id=106&cdef_id=205 HTTP/1.1" 200 3580
[17/Nov/2022:17:29:12 +0100] "POST /cdef.php?action=item_remove HTTP/1.1" 200 846
[17/Nov/2022:17:29:12 +0100] "GET /cdef.php?action=edit&header=false&id=t HTTP/1.1" 200 792

post

This?

@TheWitness
Copy link
Member

Can you capture me a screen2gif of this? Those two post variables don't make sense.

@TheWitness
Copy link
Member

Wait, CDEF ITEM damn. Wake me up.

TheWitness added a commit that referenced this issue Nov 18, 2022
@TheWitness
Fixing #5006 - CDEF/VDEF Items
cfccedd 
Cannot delete vdef and cdef item (in theme paw) - php error
@TheWitness TheWitness added confirmed Bug is confirm by dev team resolved A fixed issue and removed unable to reproduce We don't have a clue labels Nov 18, 2022
@TheWitness TheWitness added this to the v1.2.23 milestone Nov 18, 2022
@TheWitness
Copy link
Member

Fixed now.

@netniV netniV changed the title Cannot delete vdef and cdef item (in theme paw) - php error Errors can occur when attempting to remove items from CDEF or VDEF's Dec 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Undesired behaviour confirmed Bug is confirm by dev team resolved A fixed issue unverified Some days we don't have a clue
Projects
None yet
Milestone
v1.2.23
Development

No branches or pull requests
2 participants
@TheWitness @xmacan