Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree search does not correct hide non-matching tree objects #4964

Closed
anarkia1976 opened this issue Oct 19, 2022 · 4 comments
Closed

Tree search does not correct hide non-matching tree objects #4964

anarkia1976 opened this issue Oct 19, 2022 · 4 comments
Assignees
Labels
bug Undesired behaviour
Milestone

Comments

@anarkia1976
Copy link

anarkia1976 commented Oct 19, 2022

Hi Guys,

i'm using modern theme and the problem is related to:

filter the devices in the search box in the tree view show all devices.

  1. Go to Tab - Graphs.
  2. Click into box - Search.
  3. Search a specific Device or Devices with the same Description.

The problem seems to be present with all themes.

Thanks a lot for support.

@anarkia1976 anarkia1976 added bug Undesired behaviour unverified Some days we don't have a clue labels Oct 19, 2022
@TheWitness
Copy link
Member

Really not enough information. Check your browsers debug console windows for JavaScript issues. It's working fine on my test systems.

@anarkia1976
Copy link
Author

anarkia1976 commented Oct 20, 2022

The problem is the behavior of the filter.
While in the previous version when you did a search it showed only the results present in the various trees, now it shows all the devices present, highlighting the one searched for.
This is a problem as we have several folders one for each model and for each being the same customer can have a device inside.
Is there any setting to make in order to disable the expansion in the search for customers not included in the search?

You can see it in the example "step4" for the DHL search, it highlights the customer but still shows all the others.

A thousand thanks.
step1-added-new-device

step2-added-new-device-to-tree-server

step3-filter-with-new-devices-after-upgrade-is-OK

step4-filter-is-working-but-all-devices-are-displayed

@TheWitness
Copy link
Member

Yea, @browniebraun was working on it. We are chatting this morning. He'll see about getting it fixed up before the 1.2.23 release. Just keep an eye on this ticket.

@TheWitness TheWitness added this to the v1.2.23 milestone Oct 20, 2022
@browniebraun browniebraun removed the unverified Some days we don't have a clue label Nov 1, 2022
@browniebraun
Copy link
Member

Not sure if this should really be called a bug, but it is true that the search will not hide non-matching trees, branches and leafs.
From my point of view this could be added to become a filter setting in a later release, but for now I will switch it back to "normal".

Additionally the filter will not be removed if the search pattern has been cleared again character by character.

@browniebraun browniebraun changed the title [CACTI 1.2.23 - Latest Source] Impossible to filter the devices in the search box of the tree view page. [CACTI 1.2.23 - Latest Source] Tree search not hiding non-matching tree objects Nov 1, 2022
browniebraun added a commit that referenced this issue Nov 1, 2022
…be hidden. Ensure that search patterns with less than 3 characters will be ignored and all trees becomes visible.
TheWitness added a commit that referenced this issue Dec 3, 2022
Make Tree the unlock process not have to rebuild the page
@netniV netniV changed the title [CACTI 1.2.23 - Latest Source] Tree search not hiding non-matching tree objects Tree search does not correct hide non-matching tree objects Dec 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour
Projects
None yet
Development

No branches or pull requests

3 participants