Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When replicating to remote pollers, plugins are not always properly sync'd #4611

Closed
TheWitness opened this issue Mar 12, 2022 · 1 comment
Closed
Labels
bug Undesired behaviour design Design issue that blocks resolution resolved A fixed issue
Milestone

Comments

@TheWitness
Copy link
Member

Describe the bug

Several versions ago, Cacti released a plugin hook to allow plugins to replicate out their data to a remote data collectors. Now having attempted to use that hooks I'm finding it missing critical parts to properly support replication.

Expected behavior

Use of the proper hook defined to properly use the Cacti replication functions.

@TheWitness TheWitness added the bug Undesired behaviour label Mar 12, 2022
@TheWitness TheWitness added this to the v1.2.20 milestone Mar 12, 2022
@TheWitness
Copy link
Member Author

This bug fix also addresses the previously unknown case of a table that did not previously exist on the remote data collector. The logging of the SQL in those cases should not be placed in the Cacti log.

TheWitness added a commit that referenced this issue Mar 12, 2022
- Cacti's current replicate_out hook is insufficient for plugin use
- Additionally, correct issues with the current replication function to handle two exceptional case
- PHP Doc Format for several, but not all functions
- Remove a function and hook that do nothing
@TheWitness TheWitness added resolved A fixed issue design Design issue that blocks resolution labels Mar 12, 2022
@netniV netniV changed the title Cacti's current replicate_out hook is insufficient for plugin use When replicating to remote pollers, plugins are not always properly sync'd Apr 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour design Design issue that blocks resolution resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

1 participant