Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Browser Breaks Plugins that depend on non UTC date time data #4439

Closed
TheWitness opened this issue Oct 22, 2021 · 0 comments
Closed

New Browser Breaks Plugins that depend on non UTC date time data #4439

TheWitness opened this issue Oct 22, 2021 · 0 comments
Labels
bug Undesired behaviour resolved A fixed issue
Milestone

Comments

@TheWitness
Copy link
Member

TheWitness commented Oct 22, 2021

Describe the bug

Some plugins written over time rely on datetime represented data. In these cases, Cacti should provide a method to represent and evaluate that data correctly.

To Reproduce

The following steps should articulate properly.

  1. Some old plugin developer saves a datetime value in the settings table using the system time zone

  2. Later, you evaluate that data in php using you native timezone

  3. If used in the GUI, people could be confused

  4. If used for logic, bad things can happen

Expected behavior

Though it's bad carma to use datetime, it would be nice if cacti provided some simple functions to flip timezones back and forth.

@TheWitness TheWitness added bug Undesired behaviour unverified Some days we don't have a clue labels Oct 22, 2021
@TheWitness TheWitness added this to the v1.2.19 milestone Oct 22, 2021
TheWitness added a commit that referenced this issue Oct 22, 2021
New Browser Breaks Plugins that depend on non UTC date time data
@TheWitness TheWitness added resolved A fixed issue and removed unverified Some days we don't have a clue labels Oct 22, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Undesired behaviour resolved A fixed issue
Projects
None yet
Development

No branches or pull requests

1 participant