Remove deprecated $php_errormsg usage

[ddb4github]

RHEL 8.0, SLES 15, and Ubuntu 18.04 had include PHP 7.2.x Out-of-Box.

Ref: https://www.php.net/manual/en/migration72.deprecated.php:

• When the track_errors ini setting is enabled, a $php_errormsg variable is created in the
  local scope when a non-fatal error occurs. Given that the preferred way of retrieving such
  error information is by using error_get_last(), this feature has been deprecated.

./lib/html_utility.php: 
global $php_errormsg;
...
$php_error = trim(str_replace('preg_match():', '', $php_errormsg));

Possible Diff like

--- html_utility.php.orig       2019-05-09 23:29:05.862308613 +0800
+++ html_utility.php    2019-05-09 23:29:24.066158348 +0800
@@ -812,8 +812,6 @@
 }

 function validate_is_regex($regex) {
-       global $php_errormsg;
-
        if ($regex == '') {
                return true;
        }
@@ -828,7 +826,7 @@
                return true;
        }

-       $php_error = trim(str_replace('preg_match():', '', $php_errormsg));
+       $php_error = trim(str_replace('preg_match():', '', error_get_last()['message']));

        ini_set('track_errors', $track_errors);

• This function(each) is far slower at iteration than a normal foreach, and causes implementation issues for some language changes. It has therefore been deprecated.
  like #2610 Fixing

./lib/tree.php:
while (list($_tier_key, $tier_array) = each($leaf_sort_array)) {
...
while (list($_search_key, $search_array) = each($tier_array)) {
...
while (list($_tier_key, $tier_array) = each($leaf_sort_array)) {
...
while (list($_search_key, $search_array) = each($tier_array)) {
...
while (list($leaf_order_key, $leaf_title) = each($search_array)) {

./graph_settings.php:
while (list($tab_short_name, $tab_fields) = each($settings_graphs)) {
...
while (list($field_name, $field_array) = each($tab_fields)) {
...
while (list($sub_field_name, $sub_field_array) = each($field_array["items"])) {
...
while (list($sub_field_name, $sub_field_array) = each($field_array["items"])) {
...
while (list($tab_short_name, $tab_fields) = each($settings_graphs)) {
...
while (list($field_name, $field_array) = each($tab_fields)) {
...
while (list($sub_field_name, $sub_field_array) = each($field_array["items"])) {

[ddb4github]

Move graph_export.php issue to new ticket under Plugin->GExport

And open another two ticket for thold and syslog plugin

Remove phpseclib issue from above main issue desc because phpseclib add version comparing for create_function usage

Also, lib/tree.php and graph_settings.php are not exist in Cacti 1.x. It is in my dirty env.

[cigamit]

This is resolved. Thanks for verifying.