Skip to content

Commit

Permalink
Fixing Issue #4817 - Boost performance
Browse files Browse the repository at this point in the history
Boost when using RRDtool 1.5+ does not need to check last_update time
  • Loading branch information
TheWitness committed Jun 10, 2022
1 parent e09b1bd commit f3e5d93
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ Cacti CHANGELOG
-issue#4796: Hint at poller issues when boost fails
-issue#4806: Search in tree view unusable on sizeable installations
-issue#4814: When no guest template is set, login cookies are not properly set
-issue#4817: Boost when using RRDtool 1.5+ does not need to check last_update time

1.2.21
-issue#4531: Correct duplicate keys within database
Expand Down
7 changes: 6 additions & 1 deletion lib/boost.php
Original file line number Diff line number Diff line change
Expand Up @@ -757,7 +757,12 @@ function boost_process_poller_output($local_data_id = '', $rrdtool_pipe = '') {
boost_timer('rrd_filename_and_template', BOOST_TIMER_END);

boost_timer('rrd_lastupdate', BOOST_TIMER_START);
$last_update = boost_rrdtool_get_last_update_time($rrd_path, $rrdtool_pipe);
if (cacti_version_compare(get_rrdtool_version(), '1.5', '<')) {
$last_update = boost_rrdtool_get_last_update_time($rrd_path, $rrdtool_pipe);
} else {
$last_update = 0;
}

boost_timer('rrd_lastupdate', BOOST_TIMER_END);

$local_data_id = $item['local_data_id'];
Expand Down

0 comments on commit f3e5d93

Please sign in to comment.