Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation to prevent issuing certificate with disabled RA profile #889

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Add validation to prevent issuing certificate with disabled RA profile #889

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
414f454
Add validation to prevent issuing certificate with disabled RA profile
lubomirw Nov 21, 2024
1290595
Add and enable certificate issuing tests
lubomirw Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/main/java/com/czertainly/core/service/v2/impl/ClientOperationServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,14 @@ public CertificateDetailDto submitCertificateRequest(ClientCertificateRequestDto
@Transactional(Transactional.TxType.NOT_SUPPORTED)
@ExternalAuthorization(resource = Resource.RA_PROFILE, action = ResourceAction.DETAIL, parentResource = Resource.AUTHORITY, parentAction = ResourceAction.DETAIL)
public ClientCertificateDataResponseDto issueCertificate(final SecuredParentUUID authorityUuid, final SecuredUUID raProfileUuid, final ClientCertificateSignRequestDto request, final CertificateProtocolInfo protocolInfo) throws NotFoundException, CertificateException, NoSuchAlgorithmException, CertificateOperationException, CertificateRequestException {
// validate RA profile
RaProfile raProfile = raProfileRepository.findByUuidAndEnabledIsTrue(raProfileUuid.getValue())
.orElseThrow(() -> new NotFoundException(RaProfile.class, raProfileUuid));

if (Boolean.FALSE.equals(raProfile.getEnabled())) {
throw new ValidationException(String.format("Cannot issue certificate with disabled RA profile. Ra Profile: %s", raProfile.getName()));
}

ClientCertificateRequestDto certificateRequestDto = new ClientCertificateRequestDto();
certificateRequestDto.setRaProfileUuid(raProfileUuid.getValue());
certificateRequestDto.setCsrAttributes(request.getCsrAttributes());
Expand Down
Loading