Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final fixes #25

Merged
merged 8 commits into from
Oct 30, 2021
Merged

Final fixes #25

merged 8 commits into from
Oct 30, 2021

Conversation

darylhjd
Copy link
Member

Merge when everything is finished.

Lim-Shi-Han and others added 3 commits October 28, 2021 13:31
1. Change image and account details of drawerHeader
2. Remove Activity History and Help from side menu
3. Create prompt when logging out

Let me know if you all have any other things you all wanna change thanks
@Lim-Shi-Han
Copy link
Collaborator

lgtm

@darylhjd
Copy link
Member Author

wdym lgtm i just fixed a bug. smh my head

@Lim-Shi-Han
Copy link
Collaborator

But u fix alr so is good now

@Lim-Shi-Han
Copy link
Collaborator

I was saying lgtm in advance

@darylhjd
Copy link
Member Author

darylhjd commented Oct 28, 2021

But u fix alr so is good now

watch me revert commit and change history then i let u fix ok

next time i change to iphone also then i dont do anything ya woohoo!!!! LELELEL

I was saying lgtm in advance

lgtm

@Lim-Shi-Han
Copy link
Collaborator

next time i change to iphone also then i dont do anything ya woohoo!!!! LELELEL

U buy me android phone I test for u

@darylhjd
Copy link
Member Author

next time i change to iphone also then i dont do anything ya woohoo!!!! LELELEL

U buy me android phone I test for u

ltr u get android phone alr but still dont do anything how. bad boy ah

Shld we have a toast or prompt for if there is no connection to spotify or should we just leave it as it is now
@darylhjd darylhjd merged commit 0d553cb into main Oct 30, 2021
@darylhjd darylhjd deleted the fixes branch October 30, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants