Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CVSS 4.0 #249

Closed
chandanbn opened this issue Sep 21, 2023 · 5 comments
Closed

Add support for CVSS 4.0 #249

chandanbn opened this issue Sep 21, 2023 · 5 comments

Comments

@chandanbn
Copy link
Collaborator

Introduce an optional object type with cvssV4_0 field pointing to schema at https://www.first.org/cvss/cvss-v4.0.json

Likely target for 5.0.2 and before October end since this is a transparent change to CNAs.

@chandanbn chandanbn added this to the 5.0.2 milestone Sep 21, 2023
@david-waltermire
Copy link
Collaborator

Will assign to @fjscao. He committed to submit a PR by 10/8/2023.

@sei-vsarvepalli
Copy link
Contributor

Looks like the https://www.first.org/cvss/cvss-v4.0.json has an error Line 125 should be "multipleOf" instead of "multiple" - I am also writing to let the CVSS SIG know about it.
Line 121-126

        "scoreType": {
            "type": "number",
            "minimum": 0,
            "maximum": 10,
            "multiple": 0.1
        },

should be multipleOf from https://json-schema.org/understanding-json-schema/reference/numeric.html#multiples

        "scoreType": {
            "type": "number",
            "minimum": 0,
            "maximum": 10,
            "multipleOf": 0.1
        },

chandanbn added a commit that referenced this issue Oct 3, 2023
Targeting 5.1.0 with CVSS v4 capability to resolve #249
@sei-vsarvepalli
Copy link
Contributor

FIRST has released a new version at https://www.first.org/cvss/cvss-v4.0.json dated October 2, 2023

  "$id": "https://www.first.org/cvss/cvss-v4.0.json?20231002"

The CVSSv4 JSON schema error has been resolved.

@fjscao
Copy link

fjscao commented Oct 10, 2023

pull request was created on Oct. 5: #253

The other possible changes were discussed with Chandan and Dave in email.

@chandanbn
Copy link
Collaborator Author

addressed in 5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants