[APIS-989] Datatype information needs to be added. #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://jira.cubrid.org/browse/APIS-989 - Added datatype in getTypeInfo method
kisoo-han
approved these changes
Mar 7, 2024
airnet73
reviewed
Mar 7, 2024
| new Integer(10), | ||
| new Integer(11), | ||
| new Integer(22), | ||
| new Integer(26) | ||
| new Integer(29), |
There was a problem hiding this comment.
If you look at dbtype_def.h, the precision of the data type is defined.
The precision value seems to be different.
The information below is the precision of the data type.
#define DB_TIMESTAMP_PRECISION 19
#define DB_TIMESTAMPTZ_PRECISION DB_TIMESTAMP_PRECISION
#define DB_DATETIME_PRECISION 23
#define DB_DATETIMETZ_PRECISION DB_DATETIME_PRECISION
There was a problem hiding this comment.
I think you're right. I set the precision for output, but the timezone is stored separately, so the input standard seems to be correct.
It's changed.
Thanks for review.
hwany7seo
pushed a commit
to hwany7seo/cubrid-jdbc
that referenced
this pull request
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/APIS-989
Purpose
add datatype For DBeaver.
Implementation
Remarks
N/A