-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APIS-933] Can't import java.sql or javax.sql on JDK 9 or higher. (JDBC 11.1.0.0027) #37
Conversation
…BC 11.1.0.0027) http://jira.cubrid.org/browse/APIS-933 - modify build.xml for ANT Project and error should be resolved. - update patch version (11.1.0 -> 11.1.1)
'src-cubrid' in output folder is already defined. you may use it instead of 'temp-src' |
When copying from the same folder again, filterset does not work, so temp-src has been added. |
build.xml
Outdated
<mkdir dir="src"/> | ||
<copy todir="src"> | ||
<mkdir dir="${temp-src}"/> | ||
<copy todir="${temp-src}"> | ||
<fileset dir="${src}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, Only ${src}
and src
are used. ${src-cubrid}
was not used anywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
old : ${src} -> copy(include was wrong.) -> src (src same as ${src}) -> ${src-cubrid} -> build
new : ${src} -> copy(fixed incorrect include.) -> ${temp-src} -> ${src-cubrid} -> build
I just changed the src path and fixed the wrong include.
https://www.cubrid.org/manual/en/11.2/api/jdbc.html
|
User want to use jdk 1.5 or lower use the result file by self building. So I kept it. |
When I build
|
Also,
|
thank you for the report, I will consider and fix it. |
As far as I know, The Java classes for compatibility specified in available tags are accidently included in the already built jar. We already specify the minimum verions of JDK in the manual. So I thought we don't need them. Could you please elaborate why we need to support JDK 1.5 or lower? |
The reason is simple. it is already built. |
- The root path for source has been changed in 'jdbc...cubrid-src.jar'
src-cubrid: compile-cubrid: |
The verbose message explains that the files do not exist at the destination. It seems ok. |
- Missing sql-error-codes.xml
The following property may not properly be specified because it doesn't yield an absolute path.
should be
|
http://jira.cubrid.org/browse/APIS-933
Purpose
delete java, javax folder for jdk 1.6 or lower in jar file.
Implementation
Remarks
N/A