Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APIS-933] Can't import java.sql or javax.sql on JDK 9 or higher. (JDBC 11.1.0.0027) #37

Merged
merged 5 commits into from
Aug 16, 2022

Conversation

hwany7seo
Copy link
Contributor

http://jira.cubrid.org/browse/APIS-933

Purpose
delete java, javax folder for jdk 1.6 or lower in jar file.

Implementation

  • modify build.xml for ANT Project and error should be resolved.
  • update patch version (11.1.0 -> 11.1.1)

Remarks
N/A

…BC 11.1.0.0027)

http://jira.cubrid.org/browse/APIS-933

- modify build.xml for ANT Project and error should be resolved.
- update patch version (11.1.0 -> 11.1.1)
@hwany7seo hwany7seo self-assigned this Aug 12, 2022
@hgryoo
Copy link
Member

hgryoo commented Aug 12, 2022

'src-cubrid' in output folder is already defined. you may use it instead of 'temp-src'

@hwany7seo
Copy link
Contributor Author

'src-cubrid' in output folder is already defined. you may use it instead of 'temp-src'

When copying from the same folder again, filterset does not work, so temp-src has been added.

@hwany7seo hwany7seo closed this Aug 12, 2022
@hwany7seo hwany7seo reopened this Aug 12, 2022
build.xml Outdated
Comment on lines 29 to 32
<mkdir dir="src"/>
<copy todir="src">
<mkdir dir="${temp-src}"/>
<copy todir="${temp-src}">
<fileset dir="${src}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, Only ${src} and src are used. ${src-cubrid} was not used anywhere.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

old : ${src} -> copy(include was wrong.) -> src (src same as ${src}) -> ${src-cubrid} -> build
new : ${src} -> copy(fixed incorrect include.) -> ${temp-src} -> ${src-cubrid} -> build

I just changed the src path and fixed the wrong include.

@hgryoo
Copy link
Member

hgryoo commented Aug 16, 2022

https://www.cubrid.org/manual/en/11.2/api/jdbc.html
In the manual, The latest JDBC requires JDK 1.6 or later.
The following properties and conditions are obsolete. so I think we don't need to consider them anymore.

        <available property="jdk1.3+" classname="java.lang.StrictMath"/>
        <available property="jdk1.4+" classname="java.lang.CharSequence"/>
        <available property="jdk1.5+" classname="java.lang.Readable"/>
        <available property="jdk1.6+" classname="java.sql.NClob"/>
        <condition property="isUnderJDK6">
            <not>
                <equals arg1="${jdk1.6+}" arg2="true" />
            </not>
        </condition>
        <condition property="isJDK6">
            <equals arg1="${ant.java.version}" arg2="1.6" />
        </condition>

@hwany7seo
Copy link
Contributor Author

https://www.cubrid.org/manual/en/11.2/api/jdbc.html In the manual, The latest JDBC requires JDK 1.6 or later. The following properties and conditions are obsolete. so I think we don't need to consider them anymore.

        <available property="jdk1.3+" classname="java.lang.StrictMath"/>
        <available property="jdk1.4+" classname="java.lang.CharSequence"/>
        <available property="jdk1.5+" classname="java.lang.Readable"/>
        <available property="jdk1.6+" classname="java.sql.NClob"/>
        <condition property="isUnderJDK6">
            <not>
                <equals arg1="${jdk1.6+}" arg2="true" />
            </not>
        </condition>
        <condition property="isJDK6">
            <equals arg1="${ant.java.version}" arg2="1.6" />
        </condition>

User want to use jdk 1.5 or lower use the result file by self building. So I kept it.
because it is already built.

@hgryoo
Copy link
Member

hgryoo commented Aug 16, 2022

// Modify CMakeLists.txt like the following, added "-v" option.

add_custom_command(TARGET jdbc_build
  COMMAND ${ANT} -v dist-cubrid -buildfile ${CMAKE_CURRENT_SOURCE_DIR}/build.xml
   COMMENT "Build JDBC driver with Ant ..."
 )
./build.sh

When I build ANT with verbose mode, It still has a problem related to source path.

init:
    [mkdir] Created dir: /home/cubrid/cubrid-jdbc/output/temp-src
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBinaryString.java added as jdbc/cubrid/jdbc/driver/CUBRIDBinaryString.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBlob.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlob.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBlobInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlobInputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBlobOutputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlobOutputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBufferedInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedInputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBufferedOutputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedOutputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBufferedReader.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedReader.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBufferedWriter.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedWriter.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDCallableStatement.java added as jdbc/cubrid/jdbc/driver/CUBRIDCallableStatement.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDCancelQueryThread.java added as jdbc/cubrid/jdbc/driver/CUBRIDCancelQueryThread.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDClob.java added as jdbc/cubrid/jdbc/driver/CUBRIDClob.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDClobInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDClobInputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDClobOutputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDClobOutputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDClobReader.java added as jdbc/cubrid/jdbc/driver/CUBRIDClobReader.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDClobWriter.java added as jdbc/cubrid/jdbc/driver/CUBRIDClobWriter.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDComparator.java added as jdbc/cubrid/jdbc/driver/CUBRIDComparator.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDConnection.java added as jdbc/cubrid/jdbc/driver/CUBRIDConnection.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDConnectionEventListener.java added as jdbc/cubrid/jdbc/driver/CUBRIDConnectionEventListener.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDConnectionKey.java added as jdbc/cubrid/jdbc/driver/CUBRIDConnectionKey.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDConnectionPoolDataSource.java added as jdbc/cubrid/jdbc/driver/CUBRIDConnectionPoolDataSource.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDConnectionPoolManager.java added as jdbc/cubrid/jdbc/driver/CUBRIDConnectionPoolManager.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDConnectionWrapperPooling.java added as jdbc/cubrid/jdbc/driver/CUBRIDConnectionWrapperPooling.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDConnectionWrapperXA.java added as jdbc/cubrid/jdbc/driver/CUBRIDConnectionWrapperXA.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDDataSource.java added as jdbc/cubrid/jdbc/driver/CUBRIDDataSource.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDDataSourceBase.java added as jdbc/cubrid/jdbc/driver/CUBRIDDataSourceBase.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDDataSourceObjectFactory.java added as jdbc/cubrid/jdbc/driver/CUBRIDDataSourceObjectFactory.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDDatabaseMetaData.java added as jdbc/cubrid/jdbc/driver/CUBRIDDatabaseMetaData.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDDriver.java added as jdbc/cubrid/jdbc/driver/CUBRIDDriver.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDException.java added as jdbc/cubrid/jdbc/driver/CUBRIDException.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDInputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDJDBCErrorCode.java added as jdbc/cubrid/jdbc/driver/CUBRIDJDBCErrorCode.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDJdbcInfoTable.java added as jdbc/cubrid/jdbc/driver/CUBRIDJdbcInfoTable.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDKeyTable.java added as jdbc/cubrid/jdbc/driver/CUBRIDKeyTable.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDLobHandle.java added as jdbc/cubrid/jdbc/driver/CUBRIDLobHandle.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDOutResultSet.java added as jdbc/cubrid/jdbc/driver/CUBRIDOutResultSet.java doesn't exist.
...

init-jdk6:
Skipped because property 'isUnderJDK6' not set.

src-cubrid:
    [mkdir] Created dir: /home/cubrid/cubrid-jdbc/output/bin-cubrid
    [mkdir] Created dir: /home/cubrid/cubrid-jdbc/output/src-cubrid
     [copy] Copying 1 file to /home/cubrid/cubrid-jdbc/output/src-cubrid
     [copy] Copying /home/cubrid/cubrid-jdbc/output/CUBRID-JDBC-11.1.1.0028 to /home/cubrid/cubrid-jdbc/output/src-cubrid/CUBRID-JDBC-11.1.1.0028
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBinaryString.java added as jdbc/cubrid/jdbc/driver/CUBRIDBinaryString.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBlob.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlob.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBlobInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlobInputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBlobOutputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlobOutputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBufferedInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedInputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBufferedOutputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedOutputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBufferedReader.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedReader.java doesn't exist.
... 

      [jar] Building jar: /home/cubrid/cubrid-jdbc/JDBC-11.1.1.0028-cubrid-src.jar
      [jar] adding directory META-INF/
      [jar] adding entry META-INF/MANIFEST.MF
      [jar] adding entry META-INF/services/java.sql.Driver
      [jar] adding directory jdbc/
      [jar] adding directory jdbc/cubrid/
      [jar] adding directory jdbc/cubrid/jdbc/
      [jar] adding directory jdbc/cubrid/jdbc/driver/
      [jar] adding directory jdbc/cubrid/jdbc/jci/
      [jar] adding directory jdbc/cubrid/jdbc/log/
      [jar] adding directory jdbc/cubrid/jdbc/net/
      [jar] adding directory jdbc/cubrid/jdbc/util/
      [jar] adding directory jdbc/cubrid/sql/
      [jar] adding entry CUBRID-JDBC-11.1.1.0028
      [jar] adding entry jdbc/cubrid/jdbc/driver/CUBRIDBinaryString.java
      [jar] adding entry jdbc/cubrid/jdbc/driver/CUBRIDBlob.java
      [jar] adding entry jdbc/cubrid/jdbc/driver/CUBRIDBlobInputStream.java
      [jar] adding entry jdbc/cubrid/jdbc/driver/CUBRIDBlobOutputStream.java
      [jar] adding entry jdbc/cubrid/jdbc/driver/CUBRIDBufferedInputStream.java
...

compile-cubrid:
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDBinaryString.java added as jdbc/cubrid/jdbc/driver/CUBRIDBinaryString.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDBlob.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlob.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDBlobInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlobInputStream.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDBlobOutputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlobOutputStream.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDBufferedInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedInputStream.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDBufferedOutputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedOutputStream.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDBufferedReader.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedReader.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDBufferedWriter.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedWriter.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDCallableStatement.java added as jdbc/cubrid/jdbc/driver/CUBRIDCallableStatement.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDCancelQueryThread.java added as jdbc/cubrid/jdbc/driver/CUBRIDCancelQueryThread.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDClob.java added as jdbc/cubrid/jdbc/driver/CUBRIDClob.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDClobInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDClobInputStream.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDClobOutputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDClobOutputStream.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDClobReader.java added as jdbc/cubrid/jdbc/driver/CUBRIDClobReader.class doesn't exist.
...
build-cubrid:

dist-cubrid:
      [jar] Building jar: /home/cubrid/cubrid-jdbc/JDBC-11.1.1.0028-cubrid.jar
      [jar] adding directory META-INF/
      [jar] adding entry META-INF/MANIFEST.MF
      [jar] adding entry META-INF/services/java.sql.Driver
      [jar] adding directory cubrid/
      [jar] adding directory cubrid/jdbc/
      [jar] adding directory cubrid/jdbc/driver/
      [jar] adding directory cubrid/jdbc/jci/
      [jar] adding directory cubrid/jdbc/log/
      [jar] adding directory cubrid/jdbc/net/
      [jar] adding directory cubrid/jdbc/util/
      [jar] adding directory cubrid/sql/
      [jar] adding entry cubrid/jdbc/driver/CUBRIDBinaryString.class
      [jar] adding entry cubrid/jdbc/driver/CUBRIDBlob.class
      [jar] adding entry cubrid/jdbc/driver/CUBRIDBlobInputStream.class
      [jar] adding entry cubrid/jdbc/driver/CUBRIDBlobOutputStream.class
      [jar] adding entry cubrid/jdbc/driver/CUBRIDBufferedInputStream.class
      [jar] adding entry cubrid/jdbc/driver/CUBRIDBufferedOutputStream.class
      [jar] adding entry cubrid/jdbc/driver/CUBRIDBufferedReader.class
...

@hgryoo
Copy link
Member

hgryoo commented Aug 16, 2022

Also, JDBC-11.1.1.0028-cubrid.jar and JDBC-11.1.1.0028-cubrid-src.jar have different path.

[cubrid@hgryoo201 cubrid-jdbc]$ jar -tf JDBC-11.1.1.0028-cubrid-src.jar
META-INF/
META-INF/MANIFEST.MF
META-INF/services/java.sql.Driver
jdbc/
jdbc/cubrid/
jdbc/cubrid/jdbc/
jdbc/cubrid/jdbc/driver/
jdbc/cubrid/jdbc/jci/
jdbc/cubrid/jdbc/log/
jdbc/cubrid/jdbc/net/
jdbc/cubrid/jdbc/util/
jdbc/cubrid/sql/
CUBRID-JDBC-11.1.1.0028
jdbc/cubrid/jdbc/driver/CUBRIDBinaryString.java
jdbc/cubrid/jdbc/driver/CUBRIDBlob.java
jdbc/cubrid/jdbc/driver/CUBRIDBlobInputStream.java
jdbc/cubrid/jdbc/driver/CUBRIDBlobOutputStream.java
jdbc/cubrid/jdbc/driver/CUBRIDBufferedInputStream.java
jdbc/cubrid/jdbc/driver/CUBRIDBufferedOutputStream.java
[cubrid@hgryoo201 cubrid-jdbc]$ jar -tf JDBC-11.1.1.0028-cubrid.jar
META-INF/
META-INF/MANIFEST.MF
META-INF/services/java.sql.Driver
cubrid/
cubrid/jdbc/
cubrid/jdbc/driver/
cubrid/jdbc/jci/
cubrid/jdbc/log/
cubrid/jdbc/net/
cubrid/jdbc/util/
cubrid/sql/
cubrid/jdbc/driver/CUBRIDBinaryString.class
cubrid/jdbc/driver/CUBRIDBlob.class
cubrid/jdbc/driver/CUBRIDBlobInputStream.class
cubrid/jdbc/driver/CUBRIDBlobOutputStream.class
cubrid/jdbc/driver/CUBRIDBufferedInputStream.class
cubrid/jdbc/driver/CUBRIDBufferedOutputStream.class
cubrid/jdbc/driver/CUBRIDBufferedReader.class
cubrid/jdbc/driver/CUBRIDBufferedWriter.class
cubrid/jdbc/driver/CUBRIDCallableStatement.class
cubrid/jdbc/driver/CUBRIDCancelQueryThread.class
cubrid/jdbc/driver/CUBRIDClob.class
cubrid/jdbc/driver/CUBRIDClobInputStream.class
cubrid/jdbc/driver/CUBRIDClobOutputStream.class
cubrid/jdbc/driver/CUBRIDClobReader.class
cubrid/jdbc/driver/CUBRIDClobWriter.class
cubrid/jdbc/driver/CUBRIDComparator.class
cubrid/jdbc/driver/CUBRIDConnection.class
cubrid/jdbc/driver/CUBRIDConnectionEventListener.class
cubrid/jdbc/driver/CUBRIDConnectionKey.class

@hwany7seo
Copy link
Contributor Author

// Modify CMakeLists.txt like the following, added "-v" option.

add_custom_command(TARGET jdbc_build
  COMMAND ${ANT} -v dist-cubrid -buildfile ${CMAKE_CURRENT_SOURCE_DIR}/build.xml
   COMMENT "Build JDBC driver with Ant ..."
 )
./build.sh

When I build ANT with verbose mode, It still has a problem related to source path.

init:
    [mkdir] Created dir: /home/cubrid/cubrid-jdbc/output/temp-src
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBinaryString.java added as jdbc/cubrid/jdbc/driver/CUBRIDBinaryString.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBlob.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlob.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBlobInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlobInputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBlobOutputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlobOutputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBufferedInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedInputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBufferedOutputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedOutputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBufferedReader.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedReader.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBufferedWriter.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedWriter.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDCallableStatement.java added as jdbc/cubrid/jdbc/driver/CUBRIDCallableStatement.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDCancelQueryThread.java added as jdbc/cubrid/jdbc/driver/CUBRIDCancelQueryThread.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDClob.java added as jdbc/cubrid/jdbc/driver/CUBRIDClob.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDClobInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDClobInputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDClobOutputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDClobOutputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDClobReader.java added as jdbc/cubrid/jdbc/driver/CUBRIDClobReader.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDClobWriter.java added as jdbc/cubrid/jdbc/driver/CUBRIDClobWriter.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDComparator.java added as jdbc/cubrid/jdbc/driver/CUBRIDComparator.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDConnection.java added as jdbc/cubrid/jdbc/driver/CUBRIDConnection.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDConnectionEventListener.java added as jdbc/cubrid/jdbc/driver/CUBRIDConnectionEventListener.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDConnectionKey.java added as jdbc/cubrid/jdbc/driver/CUBRIDConnectionKey.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDConnectionPoolDataSource.java added as jdbc/cubrid/jdbc/driver/CUBRIDConnectionPoolDataSource.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDConnectionPoolManager.java added as jdbc/cubrid/jdbc/driver/CUBRIDConnectionPoolManager.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDConnectionWrapperPooling.java added as jdbc/cubrid/jdbc/driver/CUBRIDConnectionWrapperPooling.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDConnectionWrapperXA.java added as jdbc/cubrid/jdbc/driver/CUBRIDConnectionWrapperXA.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDDataSource.java added as jdbc/cubrid/jdbc/driver/CUBRIDDataSource.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDDataSourceBase.java added as jdbc/cubrid/jdbc/driver/CUBRIDDataSourceBase.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDDataSourceObjectFactory.java added as jdbc/cubrid/jdbc/driver/CUBRIDDataSourceObjectFactory.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDDatabaseMetaData.java added as jdbc/cubrid/jdbc/driver/CUBRIDDatabaseMetaData.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDDriver.java added as jdbc/cubrid/jdbc/driver/CUBRIDDriver.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDException.java added as jdbc/cubrid/jdbc/driver/CUBRIDException.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDInputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDJDBCErrorCode.java added as jdbc/cubrid/jdbc/driver/CUBRIDJDBCErrorCode.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDJdbcInfoTable.java added as jdbc/cubrid/jdbc/driver/CUBRIDJdbcInfoTable.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDKeyTable.java added as jdbc/cubrid/jdbc/driver/CUBRIDKeyTable.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDLobHandle.java added as jdbc/cubrid/jdbc/driver/CUBRIDLobHandle.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDOutResultSet.java added as jdbc/cubrid/jdbc/driver/CUBRIDOutResultSet.java doesn't exist.
...

init-jdk6:
Skipped because property 'isUnderJDK6' not set.

src-cubrid:
    [mkdir] Created dir: /home/cubrid/cubrid-jdbc/output/bin-cubrid
    [mkdir] Created dir: /home/cubrid/cubrid-jdbc/output/src-cubrid
     [copy] Copying 1 file to /home/cubrid/cubrid-jdbc/output/src-cubrid
     [copy] Copying /home/cubrid/cubrid-jdbc/output/CUBRID-JDBC-11.1.1.0028 to /home/cubrid/cubrid-jdbc/output/src-cubrid/CUBRID-JDBC-11.1.1.0028
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBinaryString.java added as jdbc/cubrid/jdbc/driver/CUBRIDBinaryString.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBlob.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlob.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBlobInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlobInputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBlobOutputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlobOutputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBufferedInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedInputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBufferedOutputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedOutputStream.java doesn't exist.
     [copy] jdbc/cubrid/jdbc/driver/CUBRIDBufferedReader.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedReader.java doesn't exist.
... 

      [jar] Building jar: /home/cubrid/cubrid-jdbc/JDBC-11.1.1.0028-cubrid-src.jar
      [jar] adding directory META-INF/
      [jar] adding entry META-INF/MANIFEST.MF
      [jar] adding entry META-INF/services/java.sql.Driver
      [jar] adding directory jdbc/
      [jar] adding directory jdbc/cubrid/
      [jar] adding directory jdbc/cubrid/jdbc/
      [jar] adding directory jdbc/cubrid/jdbc/driver/
      [jar] adding directory jdbc/cubrid/jdbc/jci/
      [jar] adding directory jdbc/cubrid/jdbc/log/
      [jar] adding directory jdbc/cubrid/jdbc/net/
      [jar] adding directory jdbc/cubrid/jdbc/util/
      [jar] adding directory jdbc/cubrid/sql/
      [jar] adding entry CUBRID-JDBC-11.1.1.0028
      [jar] adding entry jdbc/cubrid/jdbc/driver/CUBRIDBinaryString.java
      [jar] adding entry jdbc/cubrid/jdbc/driver/CUBRIDBlob.java
      [jar] adding entry jdbc/cubrid/jdbc/driver/CUBRIDBlobInputStream.java
      [jar] adding entry jdbc/cubrid/jdbc/driver/CUBRIDBlobOutputStream.java
      [jar] adding entry jdbc/cubrid/jdbc/driver/CUBRIDBufferedInputStream.java
...

compile-cubrid:
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDBinaryString.java added as jdbc/cubrid/jdbc/driver/CUBRIDBinaryString.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDBlob.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlob.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDBlobInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlobInputStream.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDBlobOutputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBlobOutputStream.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDBufferedInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedInputStream.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDBufferedOutputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedOutputStream.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDBufferedReader.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedReader.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDBufferedWriter.java added as jdbc/cubrid/jdbc/driver/CUBRIDBufferedWriter.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDCallableStatement.java added as jdbc/cubrid/jdbc/driver/CUBRIDCallableStatement.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDCancelQueryThread.java added as jdbc/cubrid/jdbc/driver/CUBRIDCancelQueryThread.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDClob.java added as jdbc/cubrid/jdbc/driver/CUBRIDClob.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDClobInputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDClobInputStream.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDClobOutputStream.java added as jdbc/cubrid/jdbc/driver/CUBRIDClobOutputStream.class doesn't exist.
    [javac] jdbc/cubrid/jdbc/driver/CUBRIDClobReader.java added as jdbc/cubrid/jdbc/driver/CUBRIDClobReader.class doesn't exist.
...
build-cubrid:

dist-cubrid:
      [jar] Building jar: /home/cubrid/cubrid-jdbc/JDBC-11.1.1.0028-cubrid.jar
      [jar] adding directory META-INF/
      [jar] adding entry META-INF/MANIFEST.MF
      [jar] adding entry META-INF/services/java.sql.Driver
      [jar] adding directory cubrid/
      [jar] adding directory cubrid/jdbc/
      [jar] adding directory cubrid/jdbc/driver/
      [jar] adding directory cubrid/jdbc/jci/
      [jar] adding directory cubrid/jdbc/log/
      [jar] adding directory cubrid/jdbc/net/
      [jar] adding directory cubrid/jdbc/util/
      [jar] adding directory cubrid/sql/
      [jar] adding entry cubrid/jdbc/driver/CUBRIDBinaryString.class
      [jar] adding entry cubrid/jdbc/driver/CUBRIDBlob.class
      [jar] adding entry cubrid/jdbc/driver/CUBRIDBlobInputStream.class
      [jar] adding entry cubrid/jdbc/driver/CUBRIDBlobOutputStream.class
      [jar] adding entry cubrid/jdbc/driver/CUBRIDBufferedInputStream.class
      [jar] adding entry cubrid/jdbc/driver/CUBRIDBufferedOutputStream.class
      [jar] adding entry cubrid/jdbc/driver/CUBRIDBufferedReader.class
...

thank you for the report, I will consider and fix it.

@hgryoo
Copy link
Member

hgryoo commented Aug 16, 2022

https://www.cubrid.org/manual/en/11.2/api/jdbc.html In the manual, The latest JDBC requires JDK 1.6 or later. The following properties and conditions are obsolete. so I think we don't need to consider them anymore.

        <available property="jdk1.3+" classname="java.lang.StrictMath"/>
        <available property="jdk1.4+" classname="java.lang.CharSequence"/>
        <available property="jdk1.5+" classname="java.lang.Readable"/>
        <available property="jdk1.6+" classname="java.sql.NClob"/>
        <condition property="isUnderJDK6">
            <not>
                <equals arg1="${jdk1.6+}" arg2="true" />
            </not>
        </condition>
        <condition property="isJDK6">
            <equals arg1="${ant.java.version}" arg2="1.6" />
        </condition>

User want to use jdk 1.5 or lower use the result file by self building. So I kept it. because it is already built.

As far as I know, The Java classes for compatibility specified in available tags are accidently included in the already built jar. We already specify the minimum verions of JDK in the manual. So I thought we don't need them. Could you please elaborate why we need to support JDK 1.5 or lower?

@hwany7seo
Copy link
Contributor Author

https://www.cubrid.org/manual/en/11.2/api/jdbc.html In the manual, The latest JDBC requires JDK 1.6 or later. The following properties and conditions are obsolete. so I think we don't need to consider them anymore.

        <available property="jdk1.3+" classname="java.lang.StrictMath"/>
        <available property="jdk1.4+" classname="java.lang.CharSequence"/>
        <available property="jdk1.5+" classname="java.lang.Readable"/>
        <available property="jdk1.6+" classname="java.sql.NClob"/>
        <condition property="isUnderJDK6">
            <not>
                <equals arg1="${jdk1.6+}" arg2="true" />
            </not>
        </condition>
        <condition property="isJDK6">
            <equals arg1="${ant.java.version}" arg2="1.6" />
        </condition>

User want to use jdk 1.5 or lower use the result file by self building. So I kept it. because it is already built.

As far as I know, The Java classes for compatibility specified in available tags are accidently included in the already built jar. We already specify the minimum verions of JDK in the manual. So I thought we don't need them. Could you please elaborate why we need to support JDK 1.5 or lower?

The reason is simple. it is already built.
I will consider and fix it.

- The root path for source has been changed in 'jdbc...cubrid-src.jar'
@hwany7seo
Copy link
Contributor Author

hwany7seo commented Aug 16, 2022

@hgryoo

https://www.cubrid.org/manual/en/11.2/api/jdbc.html
In the manual, The latest JDBC requires JDK 1.6 or later.
The following properties and conditions are obsolete. so I think we don't need to consider them anymore.

  • I kept support for jdk 1.5 or lower because it is already built in.
    but As checking, cubrid-jdbc already use the class for jdk 1.6 or higher.
    So removed support for jdk 1.5 and lower.

Also, JDBC-11.1.1.0028-cubrid.jar and JDBC-11.1.1.0028-cubrid-src.jar have different path.

  • fixed

When I build ANT with verbose mode, It still has a problem related to source path.

  • Files are copied normally.
    But I don't know why it looks for the file.
    Do you know how to?
    I will be debugging for a long time.
    So I'd like to do it later, because the files are copied or compiled normally.

src-cubrid:
...
[copy] cubrid/jdbc/driver/CUBRIDBinaryString.java added as cubrid/jdbc/driver/CUBRIDBinaryString.java doesn't exist.
[copy] cubrid/jdbc/driver/CUBRIDBlob.java added as cubrid/jdbc/driver/CUBRIDBlob.java doesn't exist.
[copy] cubrid/jdbc/driver/CUBRIDBlobInputStream.java added as cubrid/jdbc/driver/CUBRIDBlobInputStream.java doesn't exist.
...
[copy] Copying 98 files to /home/hwanyseo/source/fork/cubrid-jdbc/output/src-cubrid
[copy] Copying /home/hwanyseo/source/fork/cubrid-jdbc/src/jdbc/cubrid/jdbc/driver/CUBRIDBinaryString.java to /home/hwanyseo/source/fork/cubrid-jdbc/output/src-cubrid/cubrid/jdbc/driver/CUBRIDBinaryString.java
[copy] Copying /home/hwanyseo/source/fork/cubrid-jdbc/src/jdbc/cubrid/jdbc/driver/CUBRIDBlob.java to /home/hwanyseo/source/fork/cubrid-jdbc/output/src-cubrid/cubrid/jdbc/driver/CUBRIDBlob.java
[copy] Copying /home/hwanyseo/source/fork/cubrid-jdbc/src/jdbc/cubrid/jdbc/driver/CUBRIDBlobInputStream.java to /home/hwanyseo/source/fork/cubrid-jdbc/output/src-cubrid/cubrid/jdbc/driver/CUBRIDBlobInputStream.java
...

compile-cubrid:
[javac] cubrid/jdbc/driver/CUBRIDBinaryString.java added as cubrid/jdbc/driver/CUBRIDBinaryString.class doesn't exist.
[javac] cubrid/jdbc/driver/CUBRIDBlob.java added as cubrid/jdbc/driver/CUBRIDBlob.class doesn't exist.
[javac] cubrid/jdbc/driver/CUBRIDBlobInputStream.java added as cubrid/jdbc/driver/CUBRIDBlobInputStream.class doesn't exist.
...
[javac] /home/hwanyseo/source/fork/cubrid-jdbc/output/src-cubrid/cubrid/jdbc/driver/CUBRIDBinaryString.java
[javac] /home/hwanyseo/source/fork/cubrid-jdbc/output/src-cubrid/cubrid/jdbc/driver/CUBRIDBlob.java
[javac] /home/hwanyseo/source/fork/cubrid-jdbc/output/src-cubrid/cubrid/jdbc/driver/CUBRIDBlobInputStream.java

@hwany7seo hwany7seo requested a review from hgryoo August 16, 2022 04:26
@hgryoo
Copy link
Member

hgryoo commented Aug 16, 2022

@hgryoo

https://www.cubrid.org/manual/en/11.2/api/jdbc.html
In the manual, The latest JDBC requires JDK 1.6 or later.
The following properties and conditions are obsolete. so I think we don't need to consider them anymore.

  • I kept support for jdk 1.5 or lower because it is already built in.
    but As checking, cubrid-jdbc already use the class for jdk 1.6 or higher.
    So removed support for jdk 1.5 and lower.

Also, JDBC-11.1.1.0028-cubrid.jar and JDBC-11.1.1.0028-cubrid-src.jar have different path.

  • fixed

When I build ANT with verbose mode, It still has a problem related to source path.

  • Files are copied normally.
    But I don't know why it looks for the file.
    Do you know how to?
    I will be debugging for a long time.
    So I'd like to do it later, because the files are copied or compiled normally.

src-cubrid: ... [copy] cubrid/jdbc/driver/CUBRIDBinaryString.java added as cubrid/jdbc/driver/CUBRIDBinaryString.java doesn't exist. [copy] cubrid/jdbc/driver/CUBRIDBlob.java added as cubrid/jdbc/driver/CUBRIDBlob.java doesn't exist. [copy] cubrid/jdbc/driver/CUBRIDBlobInputStream.java added as cubrid/jdbc/driver/CUBRIDBlobInputStream.java doesn't exist. ... [copy] Copying 98 files to /home/hwanyseo/source/fork/cubrid-jdbc/output/src-cubrid [copy] Copying /home/hwanyseo/source/fork/cubrid-jdbc/src/jdbc/cubrid/jdbc/driver/CUBRIDBinaryString.java to /home/hwanyseo/source/fork/cubrid-jdbc/output/src-cubrid/cubrid/jdbc/driver/CUBRIDBinaryString.java [copy] Copying /home/hwanyseo/source/fork/cubrid-jdbc/src/jdbc/cubrid/jdbc/driver/CUBRIDBlob.java to /home/hwanyseo/source/fork/cubrid-jdbc/output/src-cubrid/cubrid/jdbc/driver/CUBRIDBlob.java [copy] Copying /home/hwanyseo/source/fork/cubrid-jdbc/src/jdbc/cubrid/jdbc/driver/CUBRIDBlobInputStream.java to /home/hwanyseo/source/fork/cubrid-jdbc/output/src-cubrid/cubrid/jdbc/driver/CUBRIDBlobInputStream.java ...

compile-cubrid: [javac] cubrid/jdbc/driver/CUBRIDBinaryString.java added as cubrid/jdbc/driver/CUBRIDBinaryString.class doesn't exist. [javac] cubrid/jdbc/driver/CUBRIDBlob.java added as cubrid/jdbc/driver/CUBRIDBlob.class doesn't exist. [javac] cubrid/jdbc/driver/CUBRIDBlobInputStream.java added as cubrid/jdbc/driver/CUBRIDBlobInputStream.class doesn't exist. ... [javac] /home/hwanyseo/source/fork/cubrid-jdbc/output/src-cubrid/cubrid/jdbc/driver/CUBRIDBinaryString.java [javac] /home/hwanyseo/source/fork/cubrid-jdbc/output/src-cubrid/cubrid/jdbc/driver/CUBRIDBlob.java [javac] /home/hwanyseo/source/fork/cubrid-jdbc/output/src-cubrid/cubrid/jdbc/driver/CUBRIDBlobInputStream.java

The verbose message explains that the files do not exist at the destination. It seems ok.

- Missing sql-error-codes.xml
@hgryoo
Copy link
Member

hgryoo commented Aug 16, 2022

The following property may not properly be specified because it doesn't yield an absolute path.

    <property name="output" value="output"/>

should be

<property name="output" value="${basedir}/output"/>

build.xml Outdated Show resolved Hide resolved
build.xml Outdated Show resolved Hide resolved
@hwany7seo hwany7seo merged commit e5f1ed0 into CUBRID:develop Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants