Remove requests library, fix pyogrio calls, synchronize deps #394
Conversation
| GEOSERVER_URL = os.getenv( | ||
| "RAVENPY_GEOSERVER_URL", | ||
| os.getenv("GEO_URL", "https://pavics.ouranos.ca/geoserver/"), | ||
| os.getenv("GEO_URL", f"{HOST_URL}/geoserver/"), |
There was a problem hiding this comment.
What is the default value of HOST_URL? It must be the production https://pavics.ouranos.ca/ and not the current host that can be any test servers which lack data ! Only the production server will be guarantied to have data populated.
Test servers that actually have the data can override GEO_URL or RAVENPY_HOST_URL to set it to its local Geoserver, otherwise the default must be the production Geoserver at https://pavics.ouranos.ca/geoserver/.
There was a problem hiding this comment.
Furthermore, I think RavenPy could be used as a library installed on any end user machine so the default Geoserver must be the production one, not the local one on the end user's machine (I assume HOST_URL default is the localhost, if not sorry for the false assumption).
FYI @tlvu
Changes
pyogrio(set bygeopandasnow).geopandasto v1.0.urllib{3}instead ofrequests.