Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallback in test if raven_hydro is not installed #372

Merged
merged 5 commits into from
Jun 20, 2024
Merged

Fallback in test if raven_hydro is not installed #372

merged 5 commits into from
Jun 20, 2024

Conversation

huard
Copy link
Collaborator

@huard huard commented May 31, 2024 •
edited by Zeitsperre
Loading

Fixes #371

TODO: review dependencies to make raven_hydro a "soft" dependency ?

@coveralls
Copy link

Coverage Status

coverage: 81.82% (+0.05%) from 81.773%
when pulling 96e647a on fix-371
into dbe5fbe on master.

@Zeitsperre
Copy link
Collaborator

TODO: review dependencies to make raven_hydro a "soft" dependency ?

There's no rush just yet. Let's finish updating raven-hydro first and see where it makes the most sense to add the override.

Zeitsperre
Zeitsperre reviewed Jun 13, 2024
View reviewed changes
tests/test_emulators.py Outdated Show resolved Hide resolved
@Zeitsperre Zeitsperre changed the base branch from master to raven-hydro-031 June 18, 2024 17:21
@Zeitsperre Zeitsperre merged commit 8b47515 into raven-hydro-031 Jun 20, 2024
12 checks passed
@Zeitsperre Zeitsperre deleted the fix-371 branch June 20, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow users to override installing the raven-hydro dependency
3 participants
@huard @coveralls @Zeitsperre