Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method Shortening Refactoring #68

Merged
merged 7 commits into from
Aug 10, 2023
Merged

Method Shortening Refactoring #68

merged 7 commits into from
Aug 10, 2023

Conversation

123Chan
Copy link
Contributor

@123Chan 123Chan commented Aug 10, 2023 •
edited
Loading

Refactoring finished and ready to be merged.

REFACTORING:

  • Separated methods / delegated private methods in King class
  • Separated methods / delegated private methods in LocationBitboard class
  • Separated methods / delegated private methods in ActualValidCalculator class

BUG FIX:

  • Castling is now disabled if rook to castle does not exist, i.e. captured by opponent.
  • The bug was fixed by adding an additional check in King class to see if there is a rook to move for castling.

nawarani
nawarani approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@nawarani nawarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup.

@AscendedWise
Copy link
Contributor

Thank you for going over the refactoring for the parts I mentioned earlier. Very appreciated!

@AscendedWise AscendedWise self-requested a review August 10, 2023 18:43
AscendedWise
AscendedWise approved these changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@AscendedWise AscendedWise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve!

@123Chan 123Chan merged commit 6854b4c into main Aug 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nawarani nawarani nawarani approved these changes

@AscendedWise AscendedWise AscendedWise approved these changes

@AbubakarMohidin AbubakarMohidin AbubakarMohidin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@123Chan @AscendedWise @nawarani @AbubakarMohidin