refactoring project use cases #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oject-landscape-artists into refactoring-project-use-cases
… does not work as intended
srisais
approved these changes
Aug 12, 2023
igor-kan
approved these changes
Aug 12, 2023
rtutz
approved these changes
Aug 12, 2023
There was a problem hiding this comment.
These changes are helpful in ensuring actual entities are changed as opposed to entity models for the Project Selection.
Here are some thoughts:
I think Wendy had the idea of storing all the project entities from the database in a new class (like currentProjectRepository). I think this might be the best option.
With this approach, we might have an ArrayList of all the project entities. If one needs to get deleted, we just delete that project entity from the list.
Is there a way in the testing such that we can create a fake projects.csv with only one entry with some id, then delete it and check whether it is valid or not?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes were made to the project use cases and refactoring was done. Test cases were also written, although deleteProject and deleteprojectTest has several imporant problems.