-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unlist varsYZ for compatibility with upcoming data.table #26
base: master
Are you sure you want to change the base?
Conversation
Dear @tdhock, |
Thanks for the quick response Mārtiņš ! |
I have delegated the maintenance of the package to @jvoronova (@jvoronova - is it correct?). |
Thanks for the info! I think CRAN will accept a confirmation email from your new address. |
varsYZ <- list(namesY) | ||
if (!is.null(namesZ)) varsYZ <- list(namesY, namesZ) | ||
if (length(varsYZ)==1) varsYZ <- unlist(varsYZ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
varsYZ <- list(namesY) | |
if (!is.null(namesZ)) varsYZ <- list(namesY, namesZ) | |
if (length(varsYZ)==1) varsYZ <- unlist(varsYZ) | |
varsYZ <- if (is.null(namesZ)) namesY else list(namesY, namesZ) |
varsYZ <- list(namesY1) | ||
if (!is.null(namesZ1) & !linratio) varsYZ <- list(namesY1, namesZ1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
varsYZ <- list(namesY1) | |
if (!is.null(namesZ1) & !linratio) varsYZ <- list(namesY1, namesZ1) | |
varsYZ <- if (is.null(namesZ1) || linratio) namesY1 else list(namesY1, namesZ1) |
@@ -731,7 +731,7 @@ vardcros <- function(Y, H, PSU, w_final, | |||
keyby = namesperc, .SDcols = namesY2] | |||
varsYZ <- list(namesY1) | |||
if (!is.null(namesZ1) & !linratio) varsYZ <- list(namesY1, namesZ1) | |||
|
|||
if (length(varsYZ)==1) varsYZ <- unlist(varsYZ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if (length(varsYZ)==1) varsYZ <- unlist(varsYZ) |
Hi @djhurio @JBreidaks
I see that vardpoor uses data.table::melt, which has slightly different behavior in the next planned release (currently on github only).
Using data.table from github master, we get an error when running vardpoor examples, Rdatatable/data.table#6071
To fix that error, please accept this PR (which should work with both the current version of data.table on CRAN, and on github).
After merging the PR, please submit an update to CRAN.
Thanks!