Remove some deprecation warnings #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
force-pushed
the
ae/deprecations.2
branch
from
5a4ef56
to
4074d53
Compare
yao-cqc
reviewed
Sep 6, 2024
| @@ -43,7 +43,8 @@ | |||
| SamplerV2, | |||
| RuntimeJob, | |||
| ) | |||
| from qiskit.providers.models import BackendProperties, QasmBackendConfiguration # type: ignore | |||
| from qiskit_ibm_runtime.models.backend_configuration import PulseBackendConfiguration # type: ignore | |||
There was a problem hiding this comment.
Why replacing QasmBackendConfiguration with PulseBackendConfiguration?
There was a problem hiding this comment.
Since we switched to using qiskit runtime, this is actually the type of what IBMBackend.configuration() returns. This change only corrects the typing annotations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another step towards #350 ...
I think the only deprecation warnings now are from
TketBackend, which is not so easy to update and may require a complete rewrite ...I deleted a couple of tests that use
qiskit_algorithmswhich depended on the deprecated classes. There is a similar example in the user manual. I've checked that it still works.