Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: simplify SignatureFunc and add custom arg validation. #706

Merged
merged 18 commits into from
Nov 23, 2023
Merged

feat!: simplify SignatureFunc and add custom arg validation. #706

merged 18 commits into from
Nov 23, 2023

Commits on Nov 21, 2023

  1. refactor!: add static_params to CustomSignatureFunc

    @ss2165
    ss2165 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    f313bf4 View commit details
    Browse the repository at this point in the history

  2. move functionality to SignatureFunc

    @ss2165
    ss2165 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    ccbf567 View commit details
    Browse the repository at this point in the history

  3. unify add_op methods

    @ss2165
    ss2165 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    9f760ff View commit details
    Browse the repository at this point in the history

  4. feat: allow only specifying custom validation

    @ss2165
    ss2165 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    1619d81 View commit details
    Browse the repository at this point in the history

  5. test: test custom validation is called correctly

    @ss2165
    ss2165 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    eaa7323 View commit details
    Browse the repository at this point in the history

  6. refactor: rename some things to make them clearer

    @ss2165
    ss2165 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    439f148 View commit details
    Browse the repository at this point in the history

  7. Add docstrigs

    @ss2165
    ss2165 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    2805611 View commit details
    Browse the repository at this point in the history

  8. refactor!: use dedicated structs for varargs 

    and remove the automatic closure conversion
    @ss2165
    ss2165 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    2c435ee View commit details
    Browse the repository at this point in the history

  9. fixup after merge

    @ss2165
    ss2165 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    a23e84a View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. refactor: pass opdef to binaries

    @ss2165
    ss2165 committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    2c7287a View commit details
    Browse the repository at this point in the history

  2. feat: provide simpler traits that only pass args

    @ss2165
    ss2165 committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    26b7982 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into refactor/custom-func

    @ss2165
    ss2165 committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    d8aab2d View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2023

  1. add clarifiying comments and docstrings

    @ss2165
    ss2165 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    2b75bb1 View commit details
    Browse the repository at this point in the history

  2. make SignatureFunc pub again

    @ss2165
    ss2165 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    a5b2c45 View commit details
    Browse the repository at this point in the history

  3. remove redundant function and swap arg order

    @ss2165
    ss2165 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    3f2f515 View commit details
    Browse the repository at this point in the history

  4. return error rather than panic and add commetn

    @ss2165
    ss2165 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    d135427 View commit details
    Browse the repository at this point in the history

  5. undo SignatureFunc::compute_signature

    @ss2165
    ss2165 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    5b59f51 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into refactor/custom-func

    @ss2165
    ss2165 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    db58feb View commit details
    Browse the repository at this point in the history