Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add priorities to Jira issues #546

Merged
merged 10 commits into from
Sep 27, 2023
Merged

chore: Add priorities to Jira issues #546

merged 10 commits into from
Sep 27, 2023

Conversation

croyzor
Copy link
Contributor

@croyzor croyzor commented Sep 20, 2023

No description provided.

@croyzor
Copy link
Contributor Author

croyzor commented Sep 20, 2023

This is by far the most involved thing I've done with a github action. @cqc-alec, any clues on how to test this?

@cqc-alec
Copy link
Collaborator

This is by far the most involved thing I've done with a github action. @cqc-alec, any clues on how to test this?

I can't think of a practical way to test this except (a) merge it, create an issue, see if it worked; or (b) make a test repo and a test Jira board and do the same thing there. I'd suggest (a); it's not the end of the world if it doesn't work first time.

@croyzor croyzor force-pushed the chore/issue-priority branch 12 times, most recently from 3ca6104 to 15d4d0b Compare September 22, 2023 05:48
@croyzor
Copy link
Contributor Author

croyzor commented Sep 22, 2023

I've done a little bit of sanity checking, but now I think the way to proceed is to use this in anger and see if it works

@croyzor croyzor marked this pull request as ready for review September 22, 2023 05:58
Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The github actions vscode plugin is quite useful for catching errors.

.github/workflows/issue.yml Outdated Show resolved Hide resolved
.github/workflows/issue.yml Outdated Show resolved Hide resolved
.github/workflows/issue.yml Outdated Show resolved Hide resolved
.github/workflows/issue.yml Outdated Show resolved Hide resolved
.github/workflows/issue.yml Show resolved Hide resolved
.github/workflows/issue.yml Outdated Show resolved Hide resolved
croyzor and others added 4 commits September 22, 2023 09:56
Co-authored-by: Agustín Borgna <121866228+aborgna-q@users.noreply.github.com>
Co-authored-by: Agustín Borgna <121866228+aborgna-q@users.noreply.github.com>
Co-authored-by: Agustín Borgna <121866228+aborgna-q@users.noreply.github.com>
Co-authored-by: Agustín Borgna <121866228+aborgna-q@users.noreply.github.com>
@croyzor
Copy link
Contributor Author

croyzor commented Sep 22, 2023

The github actions vscode plugin is quite useful for catching errors.

That's good to know! I was looking for some tooling to help me but didn't find this

Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should do it!
We'll need to update the other repos too.

@croyzor croyzor added this pull request to the merge queue Sep 27, 2023
Merged via the queue into main with commit b2812b3 Sep 27, 2023
6 checks passed
@croyzor croyzor deleted the chore/issue-priority branch September 27, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants