Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new] Infer extension requirements #330

Merged
merged 85 commits into from
Aug 25, 2023
Merged

[new] Infer extension requirements #330

merged 85 commits into from
Aug 25, 2023

Conversation

croyzor
Copy link
Contributor

@croyzor croyzor commented Aug 2, 2023

Add a module extension::infer, which given a Hugr attempts to infer the resource requirements where they are left open.

Addresses #425

@croyzor croyzor changed the title [new] Infer resource requirements [new] Infer extension requirements Aug 21, 2023
@croyzor croyzor linked an issue Aug 21, 2023 that may be closed by this pull request
@croyzor croyzor requested a review from ss2165 August 25, 2023 14:17
Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one outstanding clone thing but otherwise looks good

// > mb = fresh_meta()
// > add_constraint(mb, Plus(b, ma)
// > add_constraint(output, Equal(mb))
for r in delta.iter() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't look like it has been done

@croyzor croyzor enabled auto-merge August 25, 2023 15:06
@croyzor croyzor disabled auto-merge August 25, 2023 15:06
@croyzor croyzor enabled auto-merge August 25, 2023 15:08
@croyzor croyzor added this pull request to the merge queue Aug 25, 2023
Merged via the queue into main with commit 95c0b56 Aug 25, 2023
6 checks passed
@croyzor croyzor deleted the new/resource-inference branch August 25, 2023 15:11
lmondada pushed a commit that referenced this pull request Aug 28, 2023
Add a module `extension::infer`, which given a Hugr attempts to infer
the resource requirements where they are left open.

Addresses #425

---------

Co-authored-by: Seyon Sivarajah <seyon.sivarajah@quantinuum.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infer extension requirements for hugrs
2 participants