Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flatten Prim(Type/Value) in to parent enum #665

Closed
ss2165 opened this issue Nov 9, 2023 · 0 comments · Fixed by #685
Closed

Flatten Prim(Type/Value) in to parent enum #665

ss2165 opened this issue Nov 9, 2023 · 0 comments · Fixed by #685
Assignees
@ss2165

Comments

@ss2165
Copy link
Member

ss2165 commented Nov 9, 2023

Given functions and extensions can refer to other types, they are not really primitive, the distinction is not very useful. Should be very minimal in terms of API change.
@ss2165 ss2165 self-assigned this Nov 13, 2023
ss2165 added a commit that referenced this issue Nov 13, 2023
@ss2165
refactor!: Closes Flatten Prim(Type/Value) in to parent enum #665
77bec46 
BREAKING_CHANGES: In serialization, extension and function values no longer
wrapped by "pv".
ss2165 added a commit that referenced this issue Nov 13, 2023
@ss2165
refactor!: Closes Flatten Prim(Type/Value) in to parent enum #665
3551e2d 
BREAKING_CHANGES: In serialization, extension and function values no longer
wrapped by "pv".
@ss2165 ss2165 mentioned this issue Nov 13, 2023
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 14, 2023
@ss2165
refactor!: Flatten Prim(Type/Value) in to parent enum (#685)
e791c0d 
Closes #665 

BREAKING_CHANGES: In serialization, extension and function values no
longer
wrapped by "pv".
ss2165 added a commit that referenced this issue Nov 20, 2023
@ss2165
wip: constant folding
a81b599 
refactor!: Closes Flatten `Prim(Type/Value)` in to parent enum #665

BREAKING_CHANGES: In serialization, extension and function values no longer
wrapped by "pv".
ss2165 added a commit that referenced this issue Nov 23, 2023
@ss2165
wip: constant folding
0e19610 
refactor!: Closes Flatten `Prim(Type/Value)` in to parent enum #665

BREAKING_CHANGES: In serialization, extension and function values no longer
wrapped by "pv".
ss2165 added a commit that referenced this issue Nov 23, 2023
@ss2165
wip: constant folding
b690fdd 
refactor!: Closes Flatten `Prim(Type/Value)` in to parent enum #665

BREAKING_CHANGES: In serialization, extension and function values no longer
wrapped by "pv".
ss2165 added a commit that referenced this issue Nov 23, 2023
@ss2165
wip: constant folding
84a92d9 
refactor!: Closes Flatten `Prim(Type/Value)` in to parent enum #665

BREAKING_CHANGES: In serialization, extension and function values no longer
wrapped by "pv".
ss2165 added a commit that referenced this issue Nov 23, 2023
@ss2165
wip: constant folding
769d6e1 
refactor!: Closes Flatten `Prim(Type/Value)` in to parent enum #665

BREAKING_CHANGES: In serialization, extension and function values no longer
wrapped by "pv".
ss2165 added a commit that referenced this issue Dec 18, 2023
@ss2165
wip: constant folding
bffed99 
refactor!: Closes Flatten `Prim(Type/Value)` in to parent enum #665

BREAKING_CHANGES: In serialization, extension and function values no longer
wrapped by "pv".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ss2165 ss2165

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor!: Flatten PrimType/PrimValue in to parent enum CQCL/hugr
1 participant
@ss2165