Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutable views #293

Closed
aborgna-q opened this issue Jul 26, 2023 · 3 comments
Closed

Mutable views #293

aborgna-q opened this issue Jul 26, 2023 · 3 comments
Assignees
@aborgna-q
Labels
enhancement New feature or request

Comments

@aborgna-q
Copy link
Collaborator

Allow mutable region views (and flat region views).

Along this, the internal HugrMut methods should be moved to a sealed trait, and make the regions implement the public HugrMut.

Then we can add #246 to that public trait.
@aborgna-q aborgna-q added the enhancement New feature or request label Jul 26, 2023
@aborgna-q
Copy link
Collaborator Author

We should be able to move some functionality used in the builder to the public/private hugrmut

@aborgna-q aborgna-q self-assigned this Aug 10, 2023
This was referenced Aug 10, 2023
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 11, 2023
@aborgna-q
Add a root NodeHandle type param to HugrView (#398)
056da40 
I'll say this closes #380.

We could go further and add a type parameter in `Hugr<T: NodeHandle>`,
but that would probably be annoying to use and it'd break the pyo3
machinery.

Instead, most things should be interfacing via `HugrView`. #284 / #293
will move the builder references to views instead, so we will be able to
statically check the root type.
@acl-cqc
Copy link
Contributor

acl-cqc commented Sep 27, 2023

@aborgna-q should I close this now? Or do we think we want a DescendantsMut enough to keep this open? (Maybe that should be a new issue?)

@aborgna-q
Copy link
Collaborator Author

Let's close this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborgna-q aborgna-q

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acl-cqc @aborgna-q