[!!!][FEATURE] Introduce project:create console command
#86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliashaeussler
added
enhancement
|
Code Climate has analyzed commit a2ca0ca and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 97.7% (1.4% change). View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## develop #86 +/- ##
=============================================
+ Coverage 96.12% 97.66% +1.54%
- Complexity 656 692 +36
=============================================
Files 98 101 +3
Lines 2089 2186 +97
=============================================
+ Hits 2008 2135 +127
+ Misses 81 51 -30
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eliashaeussler
force-pushed
the
feature/console-command
branch
3 times, most recently
from
535b0f7
to
54636b7
Compare
eliashaeussler
force-pushed
the
feature/console-command
branch
2 times, most recently
from
2cd73a7
to
e452954
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
eliashaeussler
force-pushed
the
feature/console-command
branch
3 times, most recently
from
def22f7
to
fccfb9d
Compare
eliashaeussler
force-pushed
the
feature/console-command
branch
from
69c688a
to
b2fe203
Compare
eliashaeussler
force-pushed
the
feature/console-command
branch
from
8a66705
to
c0f8cde
Compare
|
@mteu This PR is now ready for review. |
|
Thanks, I'll see to it. |
|
@mteu ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the project creation logic is extracted into a separate console command. The command is exposed to the Composer application, allowing to execute it through Composer as
composer project:create. In order to make this change possible, the package is converted to a Composer plugin.This has no impact on the previous single use case –
composer create-project. Instead, it provides a better abstraction of the project creation logic and allows to execute the project creation with having the project builder as (dev) dependency.This also paves the way for an implementation of #85.
ToDo: