Estimate symbolic duration for Composite durations #352
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #352 +/- ##
===========================================
- Coverage 84.11% 83.02% -1.10%
===========================================
Files 82 82
Lines 14506 14562 +56
===========================================
- Hits 12202 12090 -112
- Misses 2304 2472 +168 ☔ View full report in Codecov by Sentry. |
# Conflicts: # partitura/utils/music.py
# Conflicts: # partitura/utils/music.py
| ) | ||
| continue | ||
| # Skip if start and end notes are in different voices or staves | ||
| if start_note.voice != end_note.voice or start_note.staff != end_note.staff: |
There was a problem hiding this comment.
why should we skip if we are changing staff? This could be a staff crossing voice once we fix the modeling problem of partitura with these things.
I would allow it, unless it creates problems with the actual version
There was a problem hiding this comment.
This is true. However, it created some problems with the export. This is quite tricky. The issue comes from the Tuplet objects which should have tests implemented on them. Well, I can either comment out the staff and add a NOTE that this might create errors or add it as a flag on the function (i.e. cross_staff_in_tuplets=True).
This PR addresses a minor improvement on symbolic duration estimation for composite duration, i.e. tied notes or multiple rests.
We make this a standard on the rest infilling function in
score.pyand we generally make this an option. The PR includes some improved documentation.