Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/backend/booking analytics #364

Merged
merged 11 commits into from
Sep 17, 2024
Merged

Conversation

waveyboym
Copy link
Member

@waveyboym waveyboym commented Sep 17, 2024

Description

This pr introduces 3 new endpoints for booking analytics:

  1. Top 3 bookings
  2. Historical bookings
  3. Current bookings

Fixes # (issue)
#363

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • New unit and integration tests for codecov

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@waveyboym waveyboym added type: feature A new feature type: testing This affects one or more tests For: api This is mainly for the api For: backend This is mainly for the backend code priority: high This needs/needed to be addressed as soon as possible effort: 5 This may require/required hours of work labels Sep 17, 2024
@waveyboym waveyboym self-assigned this Sep 17, 2024
@waveyboym waveyboym linked an issue Sep 17, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.24%. Comparing base (e809880) to head (47cfe8d).
Report is 12 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #364       +/-   ##
============================================
+ Coverage    68.71%   94.24%   +25.53%     
============================================
  Files           55       11       -44     
  Lines         6041     3320     -2721     
  Branches        84        0       -84     
============================================
- Hits          4151     3129     -1022     
+ Misses        1833      144     -1689     
+ Partials        57       47       -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@waveyboym waveyboym merged commit f1c0587 into develop Sep 17, 2024
8 checks passed
@waveyboym waveyboym deleted the feat/backend/booking-analytics branch September 17, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 5 This may require/required hours of work For: api This is mainly for the api For: backend This is mainly for the backend code priority: high This needs/needed to be addressed as soon as possible type: feature A new feature type: testing This affects one or more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Bookings analytics endpoints
1 participant