Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add API endpoint to get available slots for a room #332

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

waveyboym
Copy link
Member

@waveyboym waveyboym commented Aug 21, 2024

Description

This pr adds an api endpoint that will allow the mobile to request all available slots for a specific room on a specific date

Fixes # (issue)
#331

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Wrote unit tests to test ability of open slots compute function
  • Wrote unit tests to test database function under various test cases

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@waveyboym waveyboym added type: feature A new feature type: testing This affects one or more tests For: api This is mainly for the api For: backend This is mainly for the backend code priority: high This needs/needed to be addressed as soon as possible effort: 3 This can be/was resolved in minutes be requires/required deep engagement platform: mobile This is related to mobile platforms labels Aug 21, 2024
@waveyboym waveyboym added this to the Week 1 Sprint 4 milestone Aug 21, 2024
@waveyboym waveyboym self-assigned this Aug 21, 2024
@waveyboym waveyboym linked an issue Aug 21, 2024 that may be closed by this pull request
2 tasks
@waveyboym waveyboym merged commit 6c5a447 into develop Aug 21, 2024
6 checks passed
@waveyboym waveyboym deleted the feat/backend/compute-available-slots-for-a-day branch August 21, 2024 17:15
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes missing coverage. Please review.

Project coverage is 73.68%. Comparing base (94f5a4d) to head (3e08b9e).
Report is 7 commits behind head on develop.

Files Patch % Lines
occupi-backend/pkg/database/database.go 88.23% 1 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (94f5a4d) and HEAD (3e08b9e). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (94f5a4d) HEAD (3e08b9e)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #332      +/-   ##
===========================================
- Coverage    79.04%   73.68%   -5.36%     
===========================================
  Files           53       10      -43     
  Lines         3164     1923    -1241     
  Branches        81        0      -81     
===========================================
- Hits          2501     1417    -1084     
+ Misses         576      459     -117     
+ Partials        87       47      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 3 This can be/was resolved in minutes be requires/required deep engagement For: api This is mainly for the api For: backend This is mainly for the backend code platform: mobile This is related to mobile platforms priority: high This needs/needed to be addressed as soon as possible type: feature A new feature type: testing This affects one or more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Write endpoint to return available slots
1 participant