-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Sensitivity DataFrame #483
Conversation
[ENH] Sensitivity dataframe
Update as a consequence of my first contribution
@GrimFe thanks for this contribution! I think this will be a good addition. We're in the process of moving the primary development branch from develop to "main" (#474 // #466 (comment)). For this PR, that means the branch this PR should be merging into should be Can you change the destination branch to be git switch -c new-sens-dataframe main
git cherry-pick 991820e8f78eeded0e1cf4c5ff021acc11141323 3a50d1429fb9b4e978000b7922c035a307ab7f2c 6df2b83328a43235ce6ae145766e69e7db8e6c44 which will create a branch called diff --cc docs/contributors.rst
index f3647cc,d7b4c17..0000000
--- a/docs/contributors.rst
+++ b/docs/contributors.rst
@@@ -13,4 -13,4 +13,8 @@@ Here are all the wonderful people that
* `Paul Romano <https://github.com/paulromano>`_
* `Anton Travleev <https://github.com/travleev>`_
* `@nicolaborate <https://github.com/nicoloabrate>`_
++<<<<<<< HEAD
+* `@rzehumat <https://github.com/rzehumat>`_
++=======
+ * `Federico Grimaldi <https://github.com/GrimFe>`_
++>>>>>>> 6df2b83 (Update contributors.rst) I'm working on getting our testing to work with newer versions of python (we try to test against 35 and 36) in #478, so these changes still might make a situation where tests will run but some won't pass. But that'll be my problem to fix 😁 |
@drewejohnson thanks for your reply and sorry for my (very long) absence. I just tried to pull request from my develop branch to yours. Now that I did it it feels rather wrong (I am kinda new to these things so most likely it is). Maybe I should just pull from your develop first, is this the case? In parallel I am also trying what you suggested with the
Thank you very much for your support |
@GrimFe No worries. I wouldn't be in a place to hold bad feelings since I've taken so long to get back to this and #486 (which I'll get to in a bit) I take full responsibility for this situation we've found ourselves in. It was not communicated that we were shifting away from the Making comments about this and #486 at the same time. I propose the following I propose the following
|
Please add the appropriate tag to the beginning of the title of your PR:
The
toDataFrame
method was added to theSensitivityReader
class.This allows for easy energy dependent sensitivity manipulation in a pandas context and follows what was implemented for the
DepletedMaterial
class.