Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Expose DepletedMaterial data arrays as attributes #390

Merged

Conversation

drewejohnson
Copy link
Collaborator

The following attributes map directly to contents of the data dictionary, returning None if not present:

activity -> a
adens -> adens
burnup -> burnup
decayHeat -> h
ingTox -> ingTox
inhTox -> inhTox
mdens -> mdens
photonProdRate -> gsrc
spontaneousFissionRate -> sf
volume -> volume

This allows the user to perform m.adens or m.photonProdRate to directly fetch data from the data dictionary. In the future, these might be the preferred way to store / fetch data, but that's to be seen.

The docstrings have also been improved with these new quantities.

The following attributes map directly to contents of the
data dictionary, returning None if not present:

attribute -> array
activity -> a
adens -> adens
burnup -> burnup
decayHeat -> h
ingTox -> ingTox
inhTox -> inhTox
mdens -> mdens
photonProdRate -> gsrc
spontaneousFissionRate -> sf
volume -> volume
@drewejohnson drewejohnson added the API - Compatible Changes to our API that require no user actions label Mar 29, 2020
@drewejohnson drewejohnson requested a review from DanKotlyar March 29, 2020 22:05
@drewejohnson
Copy link
Collaborator Author

Travis build is good, but not reporting again for some reason...
https://travis-ci.org/github/drewejohnson/serpent-tools/builds/668503755

@drewejohnson drewejohnson merged commit fcf4aec into CORE-GATECH-GROUP:master Mar 30, 2020
@drewejohnson drewejohnson added this to the 0.9.3 milestone Apr 16, 2020
@drewejohnson drewejohnson deleted the api-dep-attributes branch April 16, 2020 12:17
drewejohnson added a commit to drewejohnson/serpent-tools that referenced this pull request May 23, 2020
Backport of features included since 0.9.3 release

Includes the following PRs

git log --online --pretty="%s" --merges 0.9.3...

Merge pull request CORE-GATECH-GROUP#407 from drewejohnson/fix-readme
Merge pull request CORE-GATECH-GROUP#406 from drewejohnson/r0.9.3
Merge pull request CORE-GATECH-GROUP#405 from nicoloabrate/master
Merge pull request CORE-GATECH-GROUP#404 from drewejohnson/update-git-attr
Merge pull request CORE-GATECH-GROUP#402 from drewejohnson/xsplot-labels
Merge pull request CORE-GATECH-GROUP#400 from drewejohnson/lib2-notes
Merge pull request CORE-GATECH-GROUP#399 from CORE-GATECH-GROUP/docs-sphinx-2.0
Merge pull request CORE-GATECH-GROUP#397 from drewejohnson/port-list-of-arrays
Merge pull request CORE-GATECH-GROUP#398 from drewejohnson/det-supers
Merge pull request CORE-GATECH-GROUP#396 from drewejohnson/df-arg-renaming
Merge pull request CORE-GATECH-GROUP#394 from drewejohnson/0.9.3-update-docs
Merge pull request CORE-GATECH-GROUP#395 from drewejohnson/hist-branch-dictlike
Merge pull request CORE-GATECH-GROUP#393 from drewejohnson/less-metadata
Merge pull request CORE-GATECH-GROUP#392 from drewejohnson/better-access
Merge pull request CORE-GATECH-GROUP#391 from drewejohnson/dep-dataframe
Merge pull request CORE-GATECH-GROUP#390 from drewejohnson/api-dep-attributes
Merge pull request CORE-GATECH-GROUP#388 from drewejohnson/xsplot-branch
Merge pull request CORE-GATECH-GROUP#378 from drewejohnson/better-build
Merge pull request CORE-GATECH-GROUP#376 from drewejohnson/unbundle-data-files
Merge pull request CORE-GATECH-GROUP#370 from drewejohnson/results-loa
Merge pull request CORE-GATECH-GROUP#369 from drewejohnson/merge-0.9.1-develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API - Compatible Changes to our API that require no user actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants