Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move log_concentration_constraints #7

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Move log_concentration_constraints #7

merged 3 commits into from
Feb 2, 2024

Conversation

stelmo
Copy link
Member

@stelmo stelmo commented Feb 1, 2024

No description provided.

@stelmo stelmo changed the base branch from master to mk-frontend-cleaning February 1, 2024 12:49
@stelmo stelmo requested a review from exaexa February 1, 2024 14:00
@exaexa exaexa changed the base branch from mk-frontend-cleaning to master February 2, 2024 08:56
@exaexa
Copy link
Member

exaexa commented Feb 2, 2024

rebasegun applied

Both things kinda assume stuff about models and use the FBC interface, so let's
put them to frontend. For FBC one it is actually nice because that does the
flux balance thing right. For the "MMDF" one I just renamed the thing to
concentrations to avoid pretending that it's MMDF-specific (it's not).
Copy link
Member

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I killed the dreaded fbc filename.

@exaexa exaexa merged commit 9ca0331 into master Feb 2, 2024
4 checks passed
@exaexa exaexa deleted the sew-move-log-conc branch February 2, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants