Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small docs improvements #20

Closed
wants to merge 21 commits into from
Closed

Small docs improvements #20

wants to merge 21 commits into from

Conversation

stelmo
Copy link
Member

@stelmo stelmo commented Apr 16, 2024

No description provided.

exaexa
exaexa reviewed Apr 16, 2024
View reviewed changes
Copy link
Member

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically ok, pls accept the mod and merge

exaexa
exaexa reviewed Apr 16, 2024
View reviewed changes
Copy link
Member

@exaexa exaexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so far, some minor comments

@stelmo
Copy link
Member Author

stelmo commented Apr 23, 2024

/format

@github-actions GitHub Actions
Copy link
Contributor

✔️ Auto-formatting triggered by this comment succeeded, commited as f2a5d7e

github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
@stelmo
automatic formatting
f2a5d7e 
triggered by @stelmo on PR #20
@stelmo stelmo force-pushed the sew-doc-improvements branch 3 times, most recently from 16c90e5 to e450124 Compare April 23, 2024 09:56
@stelmo
Copy link
Member Author

stelmo commented Apr 23, 2024

/format

@github-actions GitHub Actions
Copy link
Contributor

✔️ Auto-formatting triggered by this comment succeeded, commited as a4c16b6

github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
@stelmo
automatic formatting
a4c16b6 
triggered by @stelmo on PR #20
@stelmo stelmo requested a review from exaexa April 23, 2024 10:01
@exaexa
Copy link
Member

exaexa commented Apr 23, 2024

looks pretty good to me, with some small things to change. I'll split this up a bit and merge in smaller parts.

exaexa
exaexa reviewed Apr 25, 2024
View reviewed changes
src/frontend/community.jl
@@ -62,7 +65,7 @@ function community_flux_balance_constraints(

growth_sums = [
Symbol(k) => C.Constraint(sum_value(interface_biomass(constraints[Symbol(k)])))
for (k, _) in model_abundances
for (k, _, _) in model_abundances
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note here: this prevents people from passing in dictionaries

exaexa pushed a commit that referenced this pull request Apr 25, 2024
@stelmo @exaexa
automatic formatting
0baf442 
triggered by @stelmo on PR #20
This was referenced Apr 25, 2024
Merged
Merged
exaexa added a commit that referenced this pull request Apr 25, 2024
@exaexa
Merge pull request #30 from COBREXA/sew-src-fixes
717f4d5 
source fixes from #20
exaexa added a commit that referenced this pull request May 12, 2024
@exaexa
Merge pull request #31 from COBREXA/sew-doc-fixes
eed094e 
doc fixes from #20
@exaexa
Copy link
Member

exaexa commented May 13, 2024

@stelmo this was soaked in already in the other 2 MRs, right? If possible, can you pls check and close this?

@stelmo
Copy link
Member Author

stelmo commented May 14, 2024

Thanks for fixing it! closing :)

@stelmo stelmo closed this May 14, 2024
@stelmo stelmo deleted the sew-doc-improvements branch May 14, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exaexa exaexa exaexa left review comments

Assignees

@stelmo stelmo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stelmo @exaexa