Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement sampling #16

Merged
merged 14 commits into from
Mar 28, 2024
Merged

implement sampling #16

merged 14 commits into from
Mar 28, 2024

Conversation

exaexa
Copy link
Member

@exaexa exaexa commented Mar 26, 2024

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

Attention: Patch coverage is 98.71795% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.78%. Comparing base (72ee51b) to head (ea5a5c8).

Files Patch % Lines
src/analysis/sample.jl 98.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   91.25%   93.78%   +2.53%     
==========================================
  Files          37       37              
  Lines         446      515      +69     
==========================================
+ Hits          407      483      +76     
+ Misses         39       32       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@exaexa
Copy link
Member Author

exaexa commented Mar 26, 2024

/format

triggered by @exaexa on PR #16
Copy link
Contributor

✔️ Auto-formatting triggered by this comment succeeded, commited as 3289187

@exaexa exaexa changed the title Mk sampling implement sampling Mar 28, 2024
@exaexa exaexa requested a review from stelmo March 28, 2024 10:50
@exaexa
Copy link
Member Author

exaexa commented Mar 28, 2024

@stelmo pls any comments. I still need to somehow solve the vector wrapping atrocity in there, but that shouldn't be that harsh.

Copy link
Member

@stelmo stelmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

src/analysis/sample.jl Show resolved Hide resolved
src/analysis/sample.jl Show resolved Hide resolved
src/frontend/sample.jl Show resolved Hide resolved
@exaexa
Copy link
Member Author

exaexa commented Mar 28, 2024

actually the solution wasn't that harsh. merging.

@exaexa exaexa merged commit ce9ac79 into master Mar 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants